[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v5 2/2] x86/intel: insert Ice Lake-SP and Ice Lake-D model numbers


  • To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Sun, 25 Apr 2021 01:07:54 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cRyCHxZeb86c0G1/R7IXEyOhBEkPaNpAVBEwvRoSyno=; b=i2+2GhgRkx7lIDFcwwEGjwEuSQscrxpuOmFZf0sCgfbt+fDuQCBDHJMnCB+61pl+oEyrqFvNLhw2y0pwVeKvUhe6SSWO7Yu5rMTBnNSB+ISXCCXoVJm0bjj3XCC5a2JteELf6P0mKXaa0M7QSUdbWJJ1do/wRpP3uBAa+iVtMCbx9SJ2SzLLR2g5fUadpYir7XqNIwDFlkHMAy0cpT39/F2y9zrI8nDH0ELtUfRptq673I4U5gLndrviCNcA5VNPRBNQrwskLeVP04PnNQdE2hFwtEmOps1fiPW/otuvw25qvMAFRetbb7V6HRgaeAfj/9yg9Mk9Jm+lC4fZxEX1HQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWAnLMXNRlHnb+NcWL3zTQhM3Z/sbjjv0xkr9Fd0UgkgpoCUpt70Vmq3cD2mmyn4vB4NK/vetyWTkOnbmdVM12fAP14nl3yMj6gy0WxnpFD0RDLqA6DlzH2dsk5CX5zn6Xn8sUWq2VYbpnsyRTK5IOX1PvEZitXt2o2ShK78KERxScdgIVjI2WbN0dE7OQ08oR2ia505KpXNZHmh98KhR2BsdQ0PRvzrUHVquJgFEZyezC7yPNavJEOqmCtr9pK6bO9zkVwvfBNJacjOeWIkn8h0jlYwWrB+Vx8mt2gmGI4HVzBP3jOAP+V8HvfYcvwMyHAuIN3OAT0PuJrEVyRkHg==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=intel.com;
  • Cc: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
  • Delivery-date: Sun, 25 Apr 2021 01:08:08 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version: 11.5.1.3
  • Ironport-sdr: Zmb0g3+2S4ZlQX3ervQ4vsbvMN9dZ1gCYdbBpqrKTp1Qz/HZTQD8g+95gzH33fplMuEPWP0mzJ M4dq+xsAeGyg==
  • Ironport-sdr: AePcSC5nwzceo1taRPFG3fApFP83A/Q6gzJIdEWFc6zWDYOdI4EN+yN8gG4oueal7Clno6B+PF DOK7DONtF9GQ==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXMd7GTVAjJC2DV0yy3tll9lVDHKrEevtQ
  • Thread-topic: [PATCH v5 2/2] x86/intel: insert Ice Lake-SP and Ice Lake-D model numbers

> From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Sent: Thursday, April 15, 2021 6:04 PM
> 
> LBR, C-state MSRs should correspond to Ice Lake desktop according to
> SDM rev. 74 for both models.
> 
> Ice Lake-SP is known to expose IF_PSCHANGE_MC_NO in
> IA32_ARCH_CAPABILITIES MSR
> (as advisory tells and Whitley SDP confirms) which means the erratum is
> fixed
> in hardware for that model and therefore it shouldn't be present in
> has_if_pschange_mc list. Provisionally assume the same to be the case
> for Ice Lake-D.
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> ---
> No changes in v5.
> 
> Changes in v4:
> - now based on SDM update
> - new LBR (0x1e0)does not seem to be exposed in the docs
> 
> Changes in v3:
> - Add Ice Lake-D model numbers
> - Drop has_if_pschange_mc hunk following Tiger Lake related discussion
> ---
>  xen/arch/x86/acpi/cpu_idle.c | 2 ++
>  xen/arch/x86/hvm/vmx/vmx.c   | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
> index c092086..d788c8b 100644
> --- a/xen/arch/x86/acpi/cpu_idle.c
> +++ b/xen/arch/x86/acpi/cpu_idle.c
> @@ -181,6 +181,8 @@ static void do_get_hw_residencies(void *arg)
>      case 0x55:
>      case 0x5E:
>      /* Ice Lake */
> +    case 0x6A:
> +    case 0x6C:
>      case 0x7D:
>      case 0x7E:
>      /* Tiger Lake */
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 30c6a57..91cba19 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2990,7 +2990,7 @@ static const struct lbr_info
> *last_branch_msr_get(void)
>          /* Goldmont Plus */
>          case 0x7a:
>          /* Ice Lake */
> -        case 0x7d: case 0x7e:
> +        case 0x6a: case 0x6c: case 0x7d: case 0x7e:
>          /* Tiger Lake */
>          case 0x8c: case 0x8d:
>          /* Tremont */
> --
> 2.7.4




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.