[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] x86/vPMU: Extend vPMU support to version 5


  • To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Sun, 25 Apr 2021 01:10:15 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Pz75R9i1uLcgRh7sOihE+t3Fk3xYyqxHGE8sI8n/Rg=; b=gMuC69AvbUjmSffagVJW4rQNDUutIuzVjbbvJQwGCD6DpX1Eh4Ww+VDp3y+PHMsj1hclTgET1zhOR0+WguG7yiEmWf++D3aKctb5rB+WHd0SfK/LH6lpaSLH0cqZGCTMXdTHPxKh+oRTlYm6CmYFZEoGkxDpRdgYKsXOmjSYEZbpdUNmaGq1ZWJYv4izyRwi4I4Jyx36BCnfjsCJ+kQVwKOx4OlxtrNEQp3Gv/Nop1KZKyWmR0UBCxFpOM2bRVPMQJBLvZ+BoiyiUB+/BFEFob0ZseuX5X/cPeqeWjHDFU0TCZqTEa6wWv4Jh0KEZJK95BnloHClQRX0rEapAggnyg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/9kHF+OPuYtvDLoDU93Mx/Ytby3pWbYH9x/zNGoTi8kU1BJpIVd2eE+ye14eirb7tE0eUu3yFkG4wPyWyEnLM5d93EYtdM5VCLmX3B7+xN3lmS8+isZjyE20AV9JQFjmCk6dmoXSMIjPPMW/tgd7sVCLuZPkNc3QvYcvdKJSD90kh+QYrpE0i7hWd3BRus4V4KaBXEMPbEkg8dng4pydEagiMwkiTypghL2N0DV5k154CRxM/stqa4UrDMPw+FvJyR3F0n+1T+mnG/nTDEBGWVpYVIoFSyQyJnSmbMZsLZRzeAjvyf5hryjZxgNzGHnqRRj4KgJjDoeqXBgrBM3nA==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=intel.com;
  • Cc: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
  • Delivery-date: Sun, 25 Apr 2021 01:10:24 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version: 11.5.1.3
  • Ironport-sdr: ioOIO+BTcrUQF7jhCxbkHlfr1CAsgu3J+fPHAefhecyKKGd2BnhgK0vXECj7X5zA6lAxC59qS1 aC9VWXz01LcA==
  • Ironport-sdr: VBeTIbqsZz23ETQh6XAnM6ZHWdqIDYWawRNXR9Nqx8PZeToI3mKP+RFyaD5tm2M9xjuY3usKpX B9kZwiKAVWnA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXMIoR1jV8zFesQ0OCx12H13L7jKrEfksw
  • Thread-topic: [PATCH] x86/vPMU: Extend vPMU support to version 5

> From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Sent: Wednesday, April 14, 2021 1:25 AM
> 
> Version 5 is backwards compatible with version 3. This allows to enable
> vPMU on Ice Lake CPUs.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> ---
>  xen/arch/x86/cpu/vpmu_intel.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/x86/cpu/vpmu_intel.c
> b/xen/arch/x86/cpu/vpmu_intel.c
> index 6e97ce7..0dfc256 100644
> --- a/xen/arch/x86/cpu/vpmu_intel.c
> +++ b/xen/arch/x86/cpu/vpmu_intel.c
> @@ -839,7 +839,7 @@ int vmx_vpmu_initialise(struct vcpu *v)
>          return 0;
> 
>      if ( v->domain->arch.cpuid->basic.pmu_version <= 1 ||
> -         v->domain->arch.cpuid->basic.pmu_version >= 5 )
> +         v->domain->arch.cpuid->basic.pmu_version >= 6 )
>          return -EINVAL;
> 
>      if ( (arch_pmc_cnt + fixed_pmc_cnt) == 0 )
> @@ -909,8 +909,9 @@ int __init core2_vpmu_init(void)
>      switch ( version )
>      {
>      case 4:
> -        printk(XENLOG_INFO "VPMU: PMU version 4 is not fully supported. "
> -               "Emulating version 3\n");
> +    case 5:
> +        printk(XENLOG_INFO "VPMU: PMU version %u is not fully supported. "
> +               "Emulating version 3\n", version);
>          /* FALLTHROUGH */
> 
>      case 2:
> --
> 2.7.4




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.