[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/12] x86/p2m: set_{foreign,mmio}_p2m_entry() are HVM-only


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 29 Apr 2021 15:17:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEgcVM+Nvzkld4Ycor3ZvY74UftrxJJGUnWGGB+VW1k=; b=mPtwuhx7+XHf71oCUwSRQSs0HfSdOI1Lru9gIL36UgssPMYyUZ6gDgMS0Exi6w6cLSBkjnZmP8CdNcikjwVGsWYjUaOurZVlZZ9F/4dOSUH97dOIzHhKROJUgv1eUqW/dvV6AcMI1uhuCpjbkviehQREJZVwAnVaCCqhIwu0etaRkELTsa8fH/ewgrvKnv8zRErHXqUMQn/l96v2azhdNiQrPcMyAfEV9/7iQIoJsl9Jc6/eNJ+4KlGhtdvTPM9TCbBgsObpP/ouEuib6CX5KZjs4QKvHWSQkQG4l0L4fFB+cNAz9FfQH6zw9FqhvHDn0w7GfQQGzpyzZRnEeDEZPA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uh5Zr9fz9/X9w6BXmEcU1CpGNKkPlSh7ArrYQ4m7yvaS8scnozTrM4e5D7wfxOXjk+8Z3HHflvJEh6QgreL/3/klN/d6jMLNfelHs2oJ7wHhgYQQbULdwv0gD7q4LWShj7HgwqWQtz1iqLJI/53pIxxdmQ1RsMbiKu2gTGfJQTaGU3Wu2TjWwg145mkItO7RJXyadTqh04fSyYzIsgHYOeqmkZK09FN29OUQrn0Zt/Z3r7/ohIYj8Yfucb5C76kViTNfqiGYw6CKjJJ1DTpwBDTjrAiTnYGkj9nROsglpcIbrm3rQza080M26uA+BSb9VMeSU/1wwboUq32KwSdVmQ==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Thu, 29 Apr 2021 13:19:32 +0000
  • Ironport-hdrordr: A9a23:+Rdt7aA/qRK/I7blHeg9tMeALOonbusQ8zAX/mhLY1h8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPufVr1zrQwxYUKJ7+tUE3duGWuJJx/9oeK+VHdMgXE3Kpm2a 9kGpISNPTZEUV6gcHm4AOxDtYnx529/Lq1gPrFpk0NcShBQchbnmBEIyycFVB7QxQDKJoiDZ yH5tdGoT3IQwVsUu2QAH4ZU+/f4+DajZ6OW298OzcLyimryQmp5rnzDgSC0n4lPQ9n7L8+/Q H+4m7Ez4q5tfXT8G6460by6NBslMLl2p9/AqW3+7UoAxHNrirtW4h7Qb2Fu1kO0ZCSwXInis PFrRtlH+kb0QKpQkiPrRHg2xbt3V8VgheIoz/o4gqRneXDSD03EMZHj45CGyGpk3YIh91gzL lNm1uQqps/N2K/oA3G+9PKWxt2/3DEx0YKrOh7tQ06baIuLJVVrYAZ4XpPFoYBEC/Q+OkcYZ ZTJfCZy/BMfVyAaXfF+kFp3dy3R3w2WiyLW04Yp6WuonVrtUE863Fd6N0Un38G+p54Y55Y59 7cOqAtsL1VVMcZYY90Ge9pe7r6NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0Zobgv 36IRJlnF93X3irJdyF3ZVN/ByIan66Ry7RxsZX4IU8kqHgRYDsLTaIRDkV4oWdisRaJveed+ e4OZpQDfOmB3DpA5x10wr3XIQXBmIZVOETp9YnS3ODqs/GMeTRx6/mWceWAICoPScvW2v5DH dGdiP0Pt984keiXWK9oBW5YQKuRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbRlLsqk8el pCMKrq+5nL4FWezCLt1SFEKxBdBkFa7PHLSHVRvzIHNEvybPIlt8iAf3tRmF+KPAV2Qc+TMA M3nSU5xYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeH/ep05CZ4icLdrFRrCEiF0nQoCkh YCVCY0AmvkUh/+g6Ssi5IZQMvFccNnvQutKclI7U7EuV6kvsEpTHsDVzuIWcqa6DxeAwZ8tx lUyesykbCAkTGgJS8ajP4jOFNBUmiRHYlLFR+IfolSh7DtdjxhVGviv03rtzgDPk7Rs2kCjG 3oKiOZPcvGBVdQoVh0+Kfn+lEcTBTUQ2tALlRB9aFtH2XPvXh+ldKRbq2oym2Ldx8p2ecGKg zIZjMUPyJjz926zwSuhT6HDHkqr69eedD1PfAGSfX+y3mtIIqHmeU6BPdS5o9iL82rnekRU+ 6TEjXlWw/QOqcM4UiyqXkkMiUv9yVhvvPsxRH/7G+3mFQ4GuHfJVx6R7cdZ/GQhlKUMsqg4d Fct5YSu+D1D0DaLvih4ovTZyRYKhzSrXWtJttY4Kx8jOYXjv9LA5LfUTH0z3lJ0xU1EdfsmC olMdZGyYGEHrUqQtcbdC1Y9Gc4jdijLEMktQrtH+81FGtd+0PzDpes47DSr6AoDVDEjAzsOU OH+yk1xYaPYwKzkZobAbk3O2JYdQwV72lj5vqLc8n1BB+xf+9OuHq8PXnVSs4WdIG1XZERpA 19+deGgqu+cDf5whnZuX9DGZ11mlzXN/+aMUarAu5H89uzJFSKjO+L2aeI/UvKYAr+TV8Zi4 1DfVEXdeJZhFAZ/csK7hQ=
  • Ironport-sdr: axtOQswOmSNn1/UuQQS7fQIwFkMFrQgfkyMc77wAxMx03LGNJZvEespEilmomTdJyVDLctsiuM +v2FaiuphegE7fL3vtn4FeZNiQARmV6eIXZoxJO8446sSAWKJR9SO+WQZSlelb+vaAh0rh0Uya lV+X1hXbuwNrugOyMR/CsPPrjpOLZiXaM71eD+uR7HGI/R7Z1mZ4jB/pN66cYkRAuInClvkBau nOSkyYqd3eksrxjx0LNpbmfDX1/f2IeI4oNm9QFBVIMetpRV6Sd0/Ujrm7phEYUeyk+dLFKeBe OHc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Apr 12, 2021 at 04:05:41PM +0200, Jan Beulich wrote:
> Extend a respective #ifdef from inside set_typed_p2m_entry() to around
> all three functions. Add ASSERT_UNREACHABLE() to the latter one's safety
> check path.

Wouldn't it be better to also move the prototypes in p2m.h into a
CONFIG_HVM guarded region, so that it fails at compile time rather
than link time?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.