[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/12] x86/p2m: set_{foreign,mmio}_p2m_entry() are HVM-only
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 29 Apr 2021 17:06:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYxT9YNRP9D0r9dmMFv3NEeRnQz1i+fp5X4gJx5oSkY=; b=HL800/m5j2S2zbPfIJcglnqC+SjkR5di18r4OPeLUdD+rNCnTdUyyEm30iK49LdiNvuLHQE/LC1JpofOTidslJTFPj0qa+WYITUkffDaGGCeWcOyN100vkE3O3xTEoNeD8P1ZE8JesDqgecf1taLZiWE6QR1lY3k+unJHCcsexYYvsLAHExTDhquDAW7OwErq3nyXTNaVtiW3OxU/c+a+U6zcR1vuR4mNi5dhMjw/3/BXIopeRi+sHzuPNG7FQfew9IjaRZB2TAvAxeb09Wowyn1oCop3gtNsx0Xv4HlW/Qa+lPMGd5pAr9ywUusK8/jK5roYdAfLTZCnFiuPBfuWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3atVyNVLyqacKdamjeeLeAfF7kM6j7/bwCjFqa+jP6gl6W+mjE20rTmfQOmVPompOsEawaSxW5V2nmR5+rh6KyaQZnk90YKSzc2FD8Goxo8uBqKgvUJUkv9Tj7Ptx7Qg/crOFGC0qWVD3J7qH/f4XG64yqJLYavHhQbpKUoD272GMHCqiG9+47B2pQ+6VFrw1jBpShLqHcNBwtqZYUgte2FyZsMHy0yMFeCa8kh1gCFmy6Hgnisf24h10tMU1WDzLUh0vbS6xlWPSDSL3D1LZatgyQ+bC4PdH01ObdbmDrQJdXt29T9nH5TmKFnzsuoSGwwVi6W3AoBLGmh19fl2w==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Thu, 29 Apr 2021 15:06:52 +0000
- Ironport-hdrordr: A9a23:QvBgpqqiuoELcODvI6/r8OsaV5uWKtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQZ3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIRg/I 9aWexFBNX0ZGIQse/T6gO1Cstl5dGB/ryhi+u29QYXcShBQchbnmREIyycFVB7QxQDIJI/Go aV6MYvnUvbRV08aMOnCn4ZG9XSvtGjruOqXTcqJT4CrDOPgzSh9aLgH3Gjsis2fjtTzd4ZgA /4uiPj4KHLiZCG4z/ak1Te9pFH3Obmo+EzfPCkrugwBnHShh2zZIJnMofy8AwdhO208l4lnJ 3tjn4bTqJOwkjcdG20vhfhsjOIuFlB11bYxVCVmnflq8DiLQhKcvZpv55TcRfS9iMbzbNB+Z 9LxG6Qut52Ch7NjU3Glrz1fixqjUa9rD4el/cShRVkIO4jQYJWxLZ+wGplVLM7WA7q4oEuF+ djSOvG4uxNTF+cZ3fF+kFy3d2FRB0Ib1m7a3lHnvbQ/yldnXh/wUdd7tcYhG08+JU0TIQBz/ jYM55viKpFQqYtHONALdZEZfHyJn3GQBrKPm7XC0/gDrs7N3XErIOyx7kp+uewetgtwIEpkJ rMFHNU3FRCO37GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7lKiuGRFcyk9axovkWD8HBMs zDeq5+MrvGFy/DCIxJ1wrxV915Mn8FSvAYvd49RhaPr6vwW8jXn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3uXnf5hRPWSm78Y0CXx+M1LIHqu8wojKQdPIxFtQYYzX6j4NuQFDFEuqsqOE 1kIL3mlau/rXKs/XnB6nhoPhY1NDcX3JzQF1dx4SMaOUL9drgO//+Ff3pJ4XeBLhhjC9/NHB VHvFRx86KvJ5mWzSQvYujXdV6yvj82njanXp0ckqqM6YPZYZs+FI8hQ7E0Px7MDQZJlQFjr3 pjZAcISlTELC7njbyogfUvdafiXug5pD3uAMZP7VrDqE2XpKgUNwYmdg/rdfTSvCEDaH5/gE Zr/6oWnbya8AzfVVcXsaAfK11DaGOeHbRcKh+KDb8k1YzDcB1sTGuMmDyRgwwyfG2v7EkJmm n9N0SvCI72K0sYtXZC3qnw9lRoMm2bYkJrc3h/9ZZwDGLcpx9IoKS2T7v21mbUc0AFyO0GKj 3JCAFiVj9G1pSy1BSPniyFGmhjzpIyPvbFBLBLScCb5lq9bImJn7oBBfla4dJsM83vqPYCVa aadxWOJD31T+Mv1Ar9nAdsBABk7H0lm+jvwhvr8Syx22M+G+PbJBB+XK4ASuvsmlTMVrKNyt F0nNg1tey/PiH4bcOH07jea3pGJgnIqWC7Quk0oflvzOgPnao2G4OeXSrD1XlB0hl7NsvymU 8ESKlw4bzKOOZUDrovUjMc+kBsmMWELUMtvACzH/Q3eks1iWTHe9yO+LjFpNMUcz+8jRq1PU Pa9SJT//3IBXTekbEbDr89OmRQZgw37m948OaLao3XD0Greoh4jSqHG274dKUYTq6PXagUpF J95dqDmueMbSr22AzKp1JAU9Vz2nfiRdn3GR6GHO5D7sezNluNiLa7+cLbtkaHdRKrL0ADwZ BffUMebs5fmiAvgY0+3C+1ULH2qCse4ihjyCAikEXs1Iig6HraGk8DMRSxuOQpYQVu
- Ironport-sdr: gIPNEHYh1ImQe8UpVUOF7jTpR3YkMbGnst8+xFZmWKCAzBD0kxBdllUV3O8jyMK1o1P5PBMImj xx9TbJsFANAGv2CDm3/42Cg1VtWHsMNoAcfh+/ju5Hl9AVcrNX8O4XvYrh1aHywhEQIusH5+Ul tmR0jnlQk6lyMiDCUJs0MDweWWhFGKv3MikV2QEkg8uYQj8zm0ZAthvyonSx3x0aIXs7X6/j8i /ufQk3wePDbjXlgX3NBV4ZcFO4fqwH6HIbNcDEi9WRcQ5qAzbKUTCjBO3ODxXASosvNrMzALkP HIw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Apr 29, 2021 at 04:09:30PM +0200, Jan Beulich wrote:
> On 29.04.2021 15:17, Roger Pau Monné wrote:
> > On Mon, Apr 12, 2021 at 04:05:41PM +0200, Jan Beulich wrote:
> >> Extend a respective #ifdef from inside set_typed_p2m_entry() to around
> >> all three functions. Add ASSERT_UNREACHABLE() to the latter one's safety
> >> check path.
> >
> > Wouldn't it be better to also move the prototypes in p2m.h into a
> > CONFIG_HVM guarded region, so that it fails at compile time rather
> > than link time?
>
> In the header I'm fearing this ending up as spaghetti more than in
> the .c file.
I would just move them all into a common CONFIG_HVM section rather
than adding CONFIG_HVM guards around each of them.
> I think where possible we may want to do so once we
> have a clear / clean set of APIs which are generic vs such which
> are HVM-specific (which I expect to be the case once p2m.c as a
> whole becomes HVM-only).
Oh, I would certainly like p2m.c to be HVM-only (see my comment about
introducing a p2m-hvm.c). Anyway, my only comment was about the
header, so:
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
