[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/5] xen: Fix build when !CONFIG_GRANT_TABLE
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Connor Davis <connojdavis@xxxxxxxxx>
- Date: Mon, 17 May 2021 17:46:12 -0600
- Cc: Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair23@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 17 May 2021 23:45:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/17/21 5:22 AM, Jan Beulich wrote:
On 14.05.2021 20:53, Connor Davis wrote:
Move struct grant_table; in grant_table.h above
ifdef CONFIG_GRANT_TABLE. This fixes the following:
/build/xen/include/xen/grant_table.h:84:50: error: 'struct grant_table'
declared inside parameter list will not be visible outside of this
definition or declaration [-Werror]
84 | static inline int mem_sharing_gref_to_gfn(struct grant_table *gt,
|
There must be more to this, as e.g. the PV shim does get built with
!GRANT_TABLE. Nevertheless, ...
You are right... you're comment made me realize I had only tested this
with XEN_TARGET_ARCH=riscv64. I will rework this.
Signed-off-by: Connor Davis <connojdavis@xxxxxxxxx>
... since the potential of breaking the build is obvious enough,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
Thanks,
Connor
|
