[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/5] xen: Fix build when !CONFIG_GRANT_TABLE

On 5/17/21 5:22 AM, Jan Beulich wrote:
On 14.05.2021 20:53, Connor Davis wrote:
Move struct grant_table; in grant_table.h above
ifdef CONFIG_GRANT_TABLE. This fixes the following:

/build/xen/include/xen/grant_table.h:84:50: error: 'struct grant_table'
declared inside parameter list will not be visible outside of this
definition or declaration [-Werror]
    84 | static inline int mem_sharing_gref_to_gfn(struct grant_table *gt,
There must be more to this, as e.g. the PV shim does get built with
!GRANT_TABLE. Nevertheless, ...

Can you elaborate? I tested all defconfigs with and without grant tables

enabled on x86 and ARM and they all build fine.

Signed-off-by: Connor Davis <connojdavis@xxxxxxxxx>
... since the potential of breaking the build is obvious enough,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>






Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.