[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/libs: guest: Fix Arm build after 8fc4916daf2a
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 18 May 2021 18:05:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ez8T/bRyCzQguqJlaEIIOTkIwuzhj9Syc9PpMALLdAE=; b=aYxOocdWsyMSeuxqlhcVBL/6dshbBhmiLIG4T9tigWLFvUQ/cJ3qvr4+WSqOPeg6Ewy8rsrC41M0KWrc8VviI2qYXPNTCYb7fd1UBJA7TYsRvUHdfVRYHs1kaLZyfovuXs7Hdtb9H21TwSrl33CVDyB+3xgoJp1aBu4FgYLXeQ1G2ebaHX/R0WG2IOA7Waj8pmDxv2AmXn8Jdg7nMgMKiLVZZbS3ru807O2h60Rp5/mkH2cVKAB29n4Py5wf47GEQv5tdM+JxKAhYM/ZIEVk3a6gWsg68DHSLf11/dxlLgTkJxLkG7NAkIcpmNbNs32mvxGtSgxFIq1iY5M+7ZOuOA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gN8rbMcmv2St3Oi4PpzpbOXLaq7bCOsTUZITXDGeh735IlJf6ahGNbvbFiJ9Nvb2xj4WRr0TF00U2DSw1EZSN3wDBSUZxb5M4QT3q/+Blj5Q8aPs3087HGhAaf22YgJaxlx46EjvvhkhFZex2Of3fU9bf350HB7rriU2+7y6fyV3XzK5Q+2c6nOE5rvlyxzRJJ79yPJM2J7BPGe1NcHSli/OQnat93uLwkQeWmfbWsg1vwTnIYUmdUTeOKgGlp4DFp2n/1tOOBgdlYFgLGKoqGqSGdYXBYTJU96vbn3J6VH6o9aQq30qOJg7z6XX3wnwKunaQf1XKapPmbg/mXyCQA==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>
- Delivery-date: Tue, 18 May 2021 17:05:36 +0000
- Ironport-hdrordr: A9a23:72aP6aENXTHmcGvupLqEw8eALOsnbusQ8zAXPiFKOHlom6mj/a 2TdZsguSMc5Ax/ZJhYo6H4BEDiewK/yXcW2+ks1N6ZNWHbUQ2TQr2KhrGSoAEIdReeygdr79 YFT0EvMrbN5IBB/L3HCdODYrAdKQS8gceVbDvlvg9QpN9RGttd0zs=
- Ironport-sdr: 7Kbi1QLlQtzngWwhMSkt5sSsH8fJRLwHf4JLwhnKIYfsY3pGJs6UOd93xcjl6jqCEfbnhgr6ax Cbmq4ear9ACtoKanH0i3kHcZgoDt94gQKySsIBnOGacn0aAcNfARVGApY/zex3vX/nY4k8AIAK 4e2tDxlwHmWQKtWzdqmPd+0kL++v5R0cphcuv2KFY60nBk53UpZdq7Ld7elp8zcYO6TP5nuwiH ZMBp/t35K+HDhcjqucaRE42ePxLP93B73qIctsZh2JXg7vb1vMQ7lkTkX//TchQNFhGjXyC7R3 1kw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/05/2021 18:03, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Gitlab CI spotted an issue when building the tools Arm:
>
> xg_dom_arm.c: In function 'meminit':
> xg_dom_arm.c:401:50: error: passing argument 3 of 'set_mode' discards 'const'
> qualifier from pointer target type [-Werror=discarded-qualifiers]
> 401 | rc = set_mode(dom->xch, dom->guest_domid, dom->guest_type);
> | ~~~^~~~~~~~~~~~
>
> This is because the const was not propagated in the Arm code. Fix it
> by constifying the 3rd parameter of set_mode().
>
> Fixes: 8fc4916daf2a ("tools/libs: guest: Use const whenever we point to
> literal strings")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
