Re: [PATCH] tools/libs: guest: Fix Arm build after 8fc4916daf2a

[Julien Grall <julien@xxxxxxx>]

Hi,

On 18/05/2021 18:05, Andrew Cooper wrote:
> On 18/05/2021 18:03, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Gitlab CI spotted an issue when building the tools Arm:
> >
> > xg_dom_arm.c: In function 'meminit':
> > xg_dom_arm.c:401:50: error: passing argument 3 of 'set_mode' discards 'const' 
> > qualifier from pointer target type [-Werror=discarded-qualifiers]
> >    401 |     rc = set_mode(dom->xch, dom->guest_domid, dom->guest_type);
> >        |                                               ~~~^~~~~~~~~~~~
> >
> > This is because the const was not propagated in the Arm code. Fix it
> > by constifying the 3rd parameter of set_mode().
> >
> > Fixes: 8fc4916daf2a ("tools/libs: guest: Use const whenever we point to literal 
> > strings")
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks! I have committed with just your ack to unblock the build.

CHeers,

--
Julien Grall