[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] x86/cpuid: Drop special_features[]
On 08.06.2021 10:46, Andrew Cooper wrote: > On 08/06/2021 07:18, Jan Beulich wrote: >> On 07.06.2021 14:41, Andrew Cooper wrote: >>> While the ! annotation is useful to indicate that something special is >>> happening, an array of bits is not. Drop it, to prevent mistakes. >>> >>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> >>> --- >>> CC: Jan Beulich <JBeulich@xxxxxxxx> >>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx> >>> CC: Wei Liu <wl@xxxxxxx> >>> --- >>> xen/arch/x86/cpuid.c | 2 -- >>> xen/include/asm-x86/cpuid.h | 1 - >>> xen/tools/gen-cpuid.py | 3 --- >>> 3 files changed, 6 deletions(-) >> As osstest points out this didn't go quite far enough, or too far: >> Either XC_FEATUREMASK_SPECIAL also needs dropping (including its uses >> in libxenguest and xen-cpuid) or, considering exposing this >> information via xen-cpuid isn't entirely without purpose, the script >> part of the original change needs undoing or making conditional e.g. >> upon __XEN__. > > Yes - Gitlab CI didn't spot, because there is a different breakage from > PV32 blocking things. Oh, what further problem do we have? What I can see there (picking a random build log) is the failure from the change here ... > I think I'll reinstate the gen-cpuid.py hunks because having xen-cpuid > print out the bits when asked is helpful. And maybe put the #define inside "#ifndef __XEN__" then? Jan
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |