[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/cpuid: Drop special_features[]

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 8 Jun 2021 11:01:54 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEy4ES23OSIRiVz8iq3E31vclCeAlR3mb/3fj1yt3Tk=; b=HLp/ybkDehpHW2/tsSR5V/wHoAMDytBilOd8OSJ089RS8ePtup8FTaVugpinj3TuPEvrMw+emX7zhqDhPOpzz4gXIlAroYcaZSkYuQ/2qoierMAr4oZYh+EnOkvBEb1gMfHLaZi8fJ3bp6vo+kAed/Wa6TgoJHPlQpUz6jO+Y7+4DWiwFb/M2774h76BbTQcoTx7XNKX5IOKCwR4CyG7LlRjECwa3xQZ8JXK8MAeWDy7IMMy8GXArN5waQYqZXf3V2VdTppFtdX5LpUY50jWYGK+cLHQI4dhYXKM1yo3njX5O7k/ch4uElAaHTbELr8apuCqxWeEnrqzPpysfvfHgQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=It0uAqTEnmPZxtuyzpE96XJnQMi7eh+N3xa8w1DQ/7nMDEzkl39spWmB4Z5FZOI3eThPmUB/bfpzN+BGVSZCIXRRTAcaDN0fN5nF7GGUVXgExla2Er0MSVqzTTQIETqrjch0kHSTFicO8GFfeKW/6c7LuNegwV65Ho3pHIlUcK5i4A8cqKM6bvTovOKcqofK/b2OCLrYboklvphfljBFSYhEpxhN/HTCG8Cpo4CMM7M8t2ZVPA6Xadz/3PTlbBDb7LbNvuDy7zXzQDCjJtxhqKLRrAXxydjm7gaURVce2ndlhLIEliIrgnKjScl/xHxsi+l+xqupBPr8UjiI80xRwg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 08 Jun 2021 09:02:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.06.2021 10:46, Andrew Cooper wrote:
> On 08/06/2021 07:18, Jan Beulich wrote:
>> On 07.06.2021 14:41, Andrew Cooper wrote:
>>> While the ! annotation is useful to indicate that something special is
>>> happening, an array of bits is not.  Drop it, to prevent mistakes.
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> ---
>>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> CC: Wei Liu <wl@xxxxxxx>
>>> ---
>>>  xen/arch/x86/cpuid.c        | 2 --
>>>  xen/include/asm-x86/cpuid.h | 1 -
>>>  xen/tools/gen-cpuid.py      | 3 ---
>>>  3 files changed, 6 deletions(-)
>> As osstest points out this didn't go quite far enough, or too far:
>> Either XC_FEATUREMASK_SPECIAL also needs dropping (including its uses
>> in libxenguest and xen-cpuid) or, considering exposing this
>> information via xen-cpuid isn't entirely without purpose, the script
>> part of the original change needs undoing or making conditional e.g.
>> upon __XEN__.
> Yes - Gitlab CI didn't spot, because there is a different breakage from
> PV32 blocking things.

Oh, what further problem do we have? What I can see there (picking a
random build log) is the failure from the change here ...

> I think I'll reinstate the gen-cpuid.py hunks because having xen-cpuid
> print out the bits when asked is helpful.

And maybe put the #define inside "#ifndef __XEN__" then?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.