[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.13] compiler.h: define CONFIG_GCC_VERSION


  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 21 Jun 2021 09:14:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v8p5EWsavLYqmFEVhNRluVS3NJB+znh1u9p/pejtpCw=; b=PXeIk0ob6GiedsnyxCPC7tkCVvLIEacH8gq2NiT4RIWmooKw/2Rg77b+foCh3350qNeJThI6VwAkmHzmlkXMgiw0EqVyCx+SqTOJb8YpUAJ2kYxorGO+SWI4SYGJIyfLb8UAtVjpnpq79KUubyFGa6ygPBBwyVWwUGVpAbr4H3HHO5SI880ohuh8MdYkyatzXkk55K3eP0JM6hmEPgxEZsnLbxSLlEynAOHsfn9xwJhUSxxfuU22pE+gDIolqAVuxgGkGEki2UYNVi8pM2LoGhNTKlWIrTCeani4dnlBwAp0sF1X+pa6J7pmulElavTfqArZuzbYzuGvWiaR2pezAA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfI7pscZH+/duSoCP3VqMIpKtNleH9ZrR02j7Aw0MyAlTHVSxyW+vcN44DgHQcE4A6X4zf4bNgsOslzeTbVB7XIhjwwT59TfUvD5/pMhlLqH8PrXHdQkdXIeNGJXYdv8bGm71feqSgBjxRAGVx7pPFvTaC4GKS6xciBJH1DVvwkq6zorAUZTqBdvz0hMzeozIBrjDAYU//a2WG52VNuzrHtUjUz6suoH9NOGZFVIbajzYsIZ/rHKJ/CjnUWZan3bvU0Z33ozSA6zkiX7Dw7f5VD26HA987jpSj333ZtKWIn/l8SdgoPxDEjEkon2w4xDOMGX2gnZqs5KvWXDVuhhCg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 21 Jun 2021 07:14:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.06.2021 18:42, Olaf Hering wrote:
> Fixes commit fa5afbbc20ef3577c5338f9d0b24dad45cef59cd,
> due to lack of commit 534519f0514f52007d504e0f2eeb714de7b2468d.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit ...

> --- a/xen/include/xen/compiler.h
> +++ b/xen/include/xen/compiler.h
> @@ -99,6 +99,13 @@
>      __asm__ ("" : "=r"(__ptr) : "0"(ptr));      \
>      (typeof(ptr)) (__ptr + (off)); })
>  
> +#ifndef CONFIG_GCC_VERSION
> +# ifdef __GNUC__
> +#  define CONFIG_GCC_VERSION (__GNUC__ * 10000           \
> +                              + __GNUC_MINOR__ * 100     \
> +                              + __GNUC_PATCHLEVEL__)
> +# endif
> +#endif

... I question the need for the surrounding #ifdef, and I may also move
this higher up in the file while committing.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.