[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] tests/resource: Rework Makefile
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Jun 2021 14:42:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P81GsxTs/2DdL45WpwXDIwGJ3vkgQ2EGgQS6E3ldKns=; b=d5LdxdioawRpfUu1j9yUAkqf+FiZ6Lji0Gw3LZKxUNQ6kN6Zlm8FZLquayLWQdsttEaPOfN7Nz+dCMsqsFp4rpckYPzr6JQm1kDexRK7Dm2N95N+D3uREABcF0ASbU852LcCkaB1jIgGrMR4S9NREVU0iA1vytAUEzu6XwSZhr4xZbQqETf9SEzjqvbguChcJvc4v+ZmKY72mQ168O2oFX4X0CfVCkasR2RKuonhF8rR3cmODVIjg4K5Q5VMM4jLg6D2DM3gnSDYhpqYMG6tLGrWE1oetaeGPvmy9KJlf7sr/s36JZUNk02PCiWoGmbXFIdn2NSI1pmCFF1bOWrJDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfXQ0q4iGR/TXOxJFobspa/wsJ+BbgVO2TjvUlH4hzuZegyAEKB75tj8v4hrmaManSk1y5qsG1LQOcnNVFkxyBGBg3+wpBCBsA4RB9PGoP0uWIL+UZ4uYh4AZ+v55Wl0M+m74tl9uvGGAsIpHeCgui4ezMkZWCS1q8pIWqanRntxCJsbaLU7ZKHdERmjUSiVAVF1WvDu6aDwKXocjHw6iMjn5nnV8ZpP2FPD2rdxvML4u6PUnxQeHIRx4JOCTQT2LoICP/fNqsTgdjQt5JroUrxM3CAne5bh6D49xWC2NMpgtroCqxF8Dosi6VxqCXuLiJqFvKzFsuG1V7IuvfSRzQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 28 Jun 2021 12:42:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2021 20:21, Andrew Cooper wrote:
> In particular, fill in the install/uninstall rules so this test can be
> packaged to be automated sensibly.
>
> Make all object files depend on the Makefile, drop redundant -f's for $(RM),
> and use $(TARGET) when appropriate.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> --- a/tools/tests/resource/Makefile
> +++ b/tools/tests/resource/Makefile
> @@ -12,17 +12,20 @@ run: $(TARGET)
>
> .PHONY: clean
> clean:
> - $(RM) -f -- *.o $(TARGET) $(DEPS_RM)
> + $(RM) -- *.o $(TARGET) $(DEPS_RM)
>
> .PHONY: distclean
> distclean: clean
> - $(RM) -f -- *~
> + $(RM) -- *~
While needing to repeat very similar clean: rules in every Makefile is
already looking odd to me, having to repeat this distclean: rule
everywhere leaves me with even more question marks. But of course this
is nothing you introduce here, so merely a remark.
Jan
|
