[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] tests/cpu-policy: Rework Makefile
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Jun 2021 14:47:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIycQI4iuwXTPEuDjO3ZJ5nWRpgCyn8TiB2q9eb2DW4=; b=XPRS2W1i3lTzwz2vMIGsueDjY5rpTg/gCbIzGuCiKYITNSP7ZjruvwhTUaDH7Rp7lpwSG3PQypGJUughQ1b/7Yu82uuQHij/SH0kjuadkrGDp9jOUo0YS24Lwe5W0XZ/aalODBtlY13QqVj2pPJaJNh9h5N3B+NGAAchxqNLb5cl7n7470hXyqZi+fQy/QTD0br0TR39hvgLtJgJt8GsShxCOy+kQLd0FpowfsePyGM9y3mWd27s+1VmwCyJgqY1AX5j3sEWebpUeV7gjtjXp50n9jLZyLFswYF2TFEyUJ83CmVT3EC7ecvA4RKz8g57DiOSnimIhoB6QC6zipJbJQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q3Ub3A6ArI9bxt3a2c2/4fxfyivYpoNU9vuefVnCi7UYdL9FJCJC9fJmVp1TmO/F/WiaAQzRa7cr8Y9As02lop9z8eBiG7eL8GtTe7seYrjARhYToyi4Janb6tDrHrTLzWmeQvVZkbjm8uzrYGGDTwi6Q/v79XZyKCUEvrbpfuHPCcAVjZKum+MJURzMW6JXv+r42cj0cjcboI8ggbbZbGRNqyC0NoU4c9B+eqExF4R9mo2uu3Lpl+O7MGqdMZCdh6MgtHtt8BZWFEOweGaqD2bXBgOpYPW6jFd1RWBlew5znoDbSc5UwPNXkMpwuH5szcUGMaI2QO1uqYEdgsnuew==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 28 Jun 2021 12:48:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2021 20:21, Andrew Cooper wrote:
> @@ -23,23 +21,32 @@ run: $(TARGET-y)
>
> .PHONY: clean
> clean:
> - $(RM) -f -- *.o .*.d .*.d2 test-cpu-policy
> + $(RM) -- *.o $(TARGETS) $(DEPS_RM)
>
> .PHONY: distclean
> distclean: clean
> - $(RM) -f -- *~
> + $(RM) -- *~
>
> .PHONY: install
> install: all
> + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> + $(if $(TARGETS),$(INSTALL_PROG) $(TARGETS) $(DESTDIR)$(LIBEXEC_BIN))
>
> .PHONY: uninstall
> +uninstall:
> + $(RM) -- $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/,$(TARGETS))
>
> -CFLAGS += -Werror $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -O3
> +CFLAGS += -Werror -D__XEN_TOOLS__
> +CFLAGS += $(CFLAGS_xeninclude)
> CFLAGS += $(APPEND_CFLAGS)
>
> -vpath %.c ../../../xen/lib/x86
> +LDFLAGS += $(APPEND_LDFLAGS)
> +
> +vpath %.c $(XEN_ROOT)/xen/lib/x86
Is this a good move? In general I think relative references are better,
because it is then possible to move the tree as a whole (or access it
from multiple locations, where each one has it appearing in a different
place in the file system). I do realize though that we have many such
absolute references, so this one more isn't making things much worse.
Still
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with it left relative (or a strong reason for making it
absolute spelled out in the description).
Jan
|
