Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer

[Julien Grall <julien@xxxxxxx>]

Hi Olaf,

On 01/07/2021 12:01, Olaf Hering wrote:
> Am Thu, 1 Jul 2021 12:39:06 +0200
> schrieb Jan Beulich <jbeulich@xxxxxxxx>:
>
> > I'm afraid this goes too far: This way you remove all prior
> > (direct) maintainers (see "The meaning of nesting" in
> > ./MAINTAINERS). And I'm sure Andrew, who has written much of
> > this, ought to be considered to become the maintainer of this
> > code then as well.
> I think this was copy&paste from some other entry, which would still include 
> the tools/ maintainers when using get_maintainer.pl. I do not remember which one it 
> was.
You are mixing CCing and actual maintainers. You can be CCed without 
maintaining a directory.
Jan's point is tools/ maintainers would not be directly maintaining the 
library. You would be the sole maintainer of the directory and Jan was 
referring the following paragraph:
1. Under normal circumstances, the Ack of the most specific maintainer
is both necessary and sufficient to get a change to a given file
committed.  So a change to xen/arch/x86/mm/shadow/multi.c requires the
the Ack of the xen/arch/x86/mm/shadow maintainer for that part of the
patch, but would not require the Ack of the xen/arch/x86 maintainer or
the xen/arch/x86/mm maintainer.

Regarding your proposal to maintain the directory. I don't follow much 
the tools side and therefore can't judge the merit of the proposal.
However... this is not new code per-se and therefore the fact you touch 
last is not sufficient (otherwise I could claim the same tomorrow if I 
send a patch to the directory ;)).
For the commit message, I would suggest to provide some information 
about your contribution (including review) to the area. Also, was this 
discussed with the tools maintainers?
Cheers,

--
Julien Grall