Re: [PATCH v20210701 10/40] tools: add xc_is_known_page_type to libxenctrl

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/07/2021 10:56, Olaf Hering wrote:
> Users of xc_get_pfn_type_batch may want to sanity check the data
> returned by Xen. Add a simple helper for this purpose.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Subject needs correcting after v2.

However, given that this is in the save/restore common header, does it
really need a prefix?  Simply is_known_page_type() seems good enough.

>
> v02:
> - rename xc_is_known_page_type to sr_is_known_page_type
> - move from ctrl/xc_private.h to saverestore/common.h (jgross)
> ---
>  tools/libs/saverestore/common.h | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/tools/libs/saverestore/common.h b/tools/libs/saverestore/common.h
> index ca2eb47a4f..07c506360c 100644
> --- a/tools/libs/saverestore/common.h
> +++ b/tools/libs/saverestore/common.h
> @@ -467,6 +467,39 @@ int populate_pfns(struct xc_sr_context *ctx, unsigned 
> int count,
>  /* Handle a STATIC_DATA_END record. */
>  int handle_static_data_end(struct xc_sr_context *ctx);
>  
> +/* Sanitiy check for types returned by Xen */
> +static inline bool sr_is_known_page_type(xen_pfn_t type)

uint32_t

> +{
> +    bool ret;

The logic will be rather shorter and cleaner to read by dropping ret and
using return directly out of the switch.

> +
> +    switch (type)

Spaces.

I can fix up everything on commit if you're happy with the suggestions.

~Andrew