[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v20210701 11/40] tools: use sr_is_known_page_type
- To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 2 Jul 2021 20:27:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdVih0xujv8YQmEXpMnahM4rVK+2iTrv8F5oQBUTJx0=; b=J1m54eCE956lJbm/Ne36GRfMdwB9Vf8Pv25+7e6SKrYCzq2F7b2hPxeBOfrO3dHHod+shmlFHbJWh5pYt7L1/XsqBhSzzJl778/VwoyuC6ogykJxH4jmisGrXCgPxm7uqOOt8MRH6j7xUYtnNceDD7pfn3EEjCGzKR8eWMApbJLeqm9GuCjgJr8Pjcd8RVEOHJTzLNYCf4Xkdj5UBSETUjTT1OJtWOVVWk61xaaCdbHUoqQoy7xUgTfR9dGQOcHbIIcB+XNiZnkzRyEWeN9PkcET1GvwhJZivSsHFW+7b8wy8XcKBnBGFfl41Lbm2iAGW1ntqhnPPRHxsVUHHlskQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFREmW0qSW+js5FCssGjV33+CmubV88SX+z0J6S9d8qeMovrLFm6Mqy5ivRig2L1OQuJVRgm/baruWRDK3l5QoXsYh1HUE4ovJSBCTVstlSOMc4cWwgB2E6nXHPcMWqq8m6yPHsTFF+kAp4+BlgABMsA1NZw+CbKSgBd9/4MvXSrcPqlWvrno6fG8A2xEXhhnw5jlGFK9cQLqeVUzuc2r9Ho50psoXymE3t5cBQyG3VjbZN663B4TSyOiXU5OmN400aF5YZEi8C1zmadxBW8MNdqGfEl2lGUJAjrjbY5O93XlXDJ6gdCSLSlwepfjyT6Ph4D3VM8NIuITF6LjqyaRQ==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Juergen Gross <jgross@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 02 Jul 2021 19:27:38 +0000
- Ironport-hdrordr: A9a23:5MTxEqrI+gQyl9ZdqT3U/A4aV5vGL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBfhHO1OkPcs1NCZLXbbUQqTXf1fBO7ZogEIdBeOjdK1uZ 0QFZSWTeeAcGSS7vyKkjVQcexQuOVvmZrA7Yy1ogYPPGMaH52IrT0JbTpzencGNzWubqBJba Z0iPA3wgZINU5nFPhSURI+Lpj+TpDw5d3bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9 vnpQsmIq1Imj3sV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGpqXYIjZVZ6u ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuK4O5lbZvuH+9La1wWx4TsOscYa 9T5YDnlbZrmGqhHjXkVjIF+q30YpxbdS32N3TruaSuonJrdT5CvhMlLfck7wE9HaQGOtJ5Dt T/Q9NVfY51P4YrhIJGdao8qJiMeyDwqSylChPbHb2xLtB3B5uKke+t3IkI
- Ironport-sdr: cnogoSSIE4oS8gDmKv9t9zMdRiq3AhzJb2wkvLQ1BUT3N6p7TmXNTub01jxdJh0vteV4LJMaLu cCkEjjt0vsxK8rM9MfJoTG7EJ+nKRP/smE+CQasZtDZqUz2fOfFa94f9E5UVZwNQp+GMtxEFQc +iVKBk2XIhgfvTJOrguQXyDTAszsy3vbWaAQqqOpzVQqSL73c0dE/1CINOF6byBTi2qWfm4ick mSgUDrWg3Dhs9+HGYDFXAtceSUInjSFROGLmIUC89u1J/opKz4vy+j7gybOdiUH5V3yWvEiW7s Qnc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/07/2021 10:56, Olaf Hering wrote:
> Verify pfn type on sending side, also verify incoming batch of pfns.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Any reason this isn't folded into the previous patch, like your
subsequent two page type helper patches are?
> diff --git a/tools/libs/saverestore/save.c b/tools/libs/saverestore/save.c
> index ae3e8797d0..6f820ea432 100644
> --- a/tools/libs/saverestore/save.c
> +++ b/tools/libs/saverestore/save.c
> @@ -147,6 +147,12 @@ static int write_batch(struct xc_sr_context *ctx)
>
> for ( i = 0; i < nr_pfns; ++i )
> {
> + if ( sr_is_known_page_type(types[i]) == false )
> + {
> + ERROR("Wrong type %#"PRIpfn" for pfn %#"PRIpfn, types[i],
> mfns[i]);
"Unknown type" would be more accurate.
~Andrew
|
