[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/Makefile: drop -Werror

  • To: Elliott Mitchell <ehem+xen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 5 Jul 2021 10:09:36 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L3ukqdqargNajk7QomIvgd+mfoUGfHQ8FSpzdFZYCqQ=; b=GbrempDH+y3B1s39Eo6j5ZweAGdGDxDLE+1ES593WnUYNRcGLyeQfy9Usq1aCGf25hqExG0nzsLMZam+2N7D59RGhZl/aNKrIXA/B2o2gmbcM9DnCSLT440th9i/2ttQtuseMAydgC39x9JBjmZqAZwFsanl+ck4+CbQQuY9TUWg5yqbp7gvv4N6gzSuLc12WYg8UYadvv+A2ZYuH4QvSLSCSFyDR9BQE3fNW04g1zejvpupmE1bcAoSVCDoeuXvilv3ge+htimC7CiDAD1rTYY3J7hW5L3p4l7VZ72uKwxMF3cD+s4ltFBZwhn3rZc1lt6Jjwv040GOvA1LwcLeRw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Se/4kbrB4gyekeCJKQbnUfzb+maUEUaooM6gS5iBcyMGaarmIBZeWjRGDtZm0xqplKNXZyuoxkIq0du6XKVgdopAPzzh3wi6Hv4xIgi9DNNuvhLYCd/k095RpdGhkQuVNpP8mvmSzk7FVt32FEJk3/RRpASfMYoyCJLlx9u8ybX6jyF4lAZP1+8BQNLH8wTtImlrh2pylx+UAy35ZTVE/wwcSnC8ySb4v2fW9Jp6JaB0qLxbrf/Oziwv+N/ant23FcOYvYahu3zSex2es9p9bGfNpZpKnPVts7+JinJIV81Ji/4/hvzuLqgqw9I96AoGJpGqvpQZCXcb9OgZ+K3LHw==
  • Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
  • Delivery-date: Mon, 05 Jul 2021 08:09:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.07.2021 20:52, Elliott Mitchell wrote:
> On Fri, Jul 02, 2021 at 07:51:55PM +0200, Fabrice Fontaine wrote:
>> I do agree that setting -Werror is generally perfectly valid for upstream.
>> However, for downstream packager, it is generally seen as an issue as
>> it will always raise unexepected build failures with older, newer, or
>> exotic toolchains, see
>> https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend.
>> It would be good to, at least, have an option to disable -Werror for
>> example through a XEN_DISABLE_WERROR.
> Two people don't make it a majority opinion, but if this was a meeting
> this opinion would get a second.
> I don't know where everyone is on the spectrum, but I also strongly
> dislike -Werror yet do like -Wall and tend to get rid of warnings.
> -Werror is good for continuous integration systems, not so great for
> releases or active development.

Well, my experience with Linux (when I started working there alongside
working on Xen, many years ago) was that many people don't care at all
about compiler warnings their code changes introduce. While Linux has
improved some, I'm still carrying a fair size patch to silence all the
warnings that I observe on various build systems (i.e. with various
compiler versions). I do this because in a build with (perhaps many)
pre-existing warnings it is far easier to miss the one you accidentally
introduce with some code change. -Werror is an imo very appropriate
measure to get people to at least address the warnings they can easily
observe about everywhere. IOW I've always been appreciating Xen being
different from Linux in this regard.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.