[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86/mem-sharing: ensure consistent lock order in get_two_gfns()


  • To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 6 Jul 2021 15:13:58 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cEitWQbh6r5Ml9jJh6pdJ/XnLG4kfdRcYiO145Mh6GQ=; b=U4DPmIfI3hqIkID/vaeyvs2ldSzbOpP8v+WW/mSKyiT+NEZJsRnNOzVSEp1F4GzgS5ifxFds6d/lvAVNMupYuvK1XQvtCdH2gKYYlhHjzeB5CoZkUN3wqNT/GbNUuzf28RXzXC3T8KFYTALMjGPNMnAA2AeQcQV/qcpt2pZFvvqoLslQiSOMFc1/p6/iDPZsvAVYFejLAxPCMfCS2z0m6QjSPvUQpQzivjUHaFcmhMBlXraIjASQpn6LF2d4P4b5F96XU496TCBc3qQLMJPNRYufIJBmExgC37RpBlP+V7Cl9CoNzSQKourKLPIIoYc54LnSC4xTaLY3yaWmeyU2jQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9Oy8jnJu8CQWzi4Lu2701Hm7B3JE6VJ7ZolIf+9pAxowUnR5EmkiYvYbi/rElK6O1bTdG9T0T93vCGFbWqG+SfOHuvxLjdI0g+uG4ur33iw1CU/qzW6/3V9uFQPKI+wZ8bTkcJsASmVu//ArLbOuvPjaDmlF0VWZ+xa5CV3QWos7Wh7XKbJWtJfsGFw7ieTsjwBW2dvZrfxmVOtmpmYywzE1NAMSCtAgHzYRMMsCkfWqYNnkZ2i7IoftBEFer7z/3W7YysQGMi9KInmIf8HMVXvAfIl4iCKlCN6DDUp74RHvZsOw5NYfky7OWla4kyKidcV8+zpLpKWpX/RnSq5Pg==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 13:14:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.07.2021 14:36, Tamas K Lengyel wrote:
> On Tue, Jun 29, 2021 at 8:54 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> While the comment validly says "Sort by domain, if same domain by gfn",
>> the implementation also included equal domain IDs in the first part of
>> the check, thus rending the second part entirely dead and leaving
>> deadlock potential when there's only a single domain involved.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

Thanks. Do you think I should queue this for backporting (once it got
applied)?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.