[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/migration: Fix potential overflow in send_checkpoint_dirty_pfn_list()
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 6 Jul 2021 14:19:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hx9FQ+vn5F955hOh0gDogUnRJixPrGhm4QMBRNQC6ho=; b=JcEqZNGp8fFdv8OAzqYiCoE+TouMtCcfplet1CzIKyO+Pwszf3IM7t84Rp1GDQHgLCZv53vVmgyC2ukW1y5PJLGQdZagqGCQcTPB5klcHTgWnn02Q6ozg7kodTQ9vGr0r1C09LgQ6C14TW7i0Q/jAmgTv6mC+01oD+Qx7+qHWMfeArMJt4MMr/fsxGp6BUgP8w1p3jdvSB1jfpc13ISWDl7nfa/sicT8FSb8gtgZTHR2HfNuYVgZE27ANtkNzxfkwALVFPzEbb3GsTeunysHvUDy2WXelP5X7nnkGtP0+NduhUxMYdkEbtC20lyFB7nJMLiAt1j9iey/WU0/cVDpUQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KBhFfACE4O9sdV5oQSj5BYfuIst3/tbbCJAk++Vqq9tmVlOv8gr37Q2FbRYnIX8sJmcjZt99wjssg21jYOeL+rLO+ZLgJOz9esujo4/Drvf40BnzQbcEMihernaNytKITZfwWw37lOx4VUiWdt4d5B4Qw9poXZcLLEMPuKIfh6PMAzyW9Y+qFHAZNHJLS5DSw5D29D0Glt/9kLbnXBU3iUpdxTGoWOHG5Jdpqf1DVlxmxbu3VCkAjdMzEGboxv9eXimuEpI642D38JbJx9D+6VKU4fYxY/UcAPnpnWFxHEBO+kkjuavuo8eWwZXb5n+wqwnoGrtLyg8zqa3eKtPq7w==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 13:19:38 +0000
- Ironport-hdrordr: A9a23:AcfhPqoAaDrEWEo5wM+ww8gaV5taLNV00zEX/kB9WHVpm5Oj5r 2TdaUgpGXJYWgqKQodcIi7SeK9qBPnmaKc4eEqTMSftXrdySGVxeBZnNHfKljbcVyDygcz79 YWT0ETMqyAMbE+t7ez3ODaKad8/DDkytHfuQ629R4EIHAMGscQl3YHe3im+w9NNUB77PICf6 Z0jfA31QZIDE5nGvhTcUN1KtQryee75K4P6HU9dmcaAIfnt1zYwYITz3Cjr0EjuyAl+9kf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi+AOQw+c1TqAVcBEYfmvrTo1qOag5BIBi9 /XuSotOMx19jf4Yny1mx3wwAPtuQxetUMKiGXo0EcLk/aJFw7SOPAx176xtSGpvnbIiesMgJ 6jGVjp46a/QymwyxgVrOK4Gy2C3nDE7kYKoKo2g3tDUY0YctZq3MEiFEE/KvY99XXBiLzPVt MeUP01vJxtADCnh3ezhBgM/DSrNU5DeytvRiM5y6io+ikTk3Zjw0QCwssD2n8G6ZImUpFBo/ /JK6Jyidh1P5YrhI9GdaA8qPGMeyrwqNP3QSCvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93nJ jaSltXuWM7ZkqrUKS1rcZ22wGIRH/4USXmy8lY6ZQ8srrgRKDzOSnGTFw1icOvr/gWH8WeUf euP5BdBePlMALVaN50Ns3FKt1vwFwlIY4oU/oAKhOzS/PwW8jXX7bgAbjuzZLWYHYZZl8=
- Ironport-sdr: eUajzpOtUVAX3ruXP8kzyTt2WqAKfEvQ6K1KgZinW3skTL0jtbjOowBudh+i2ukfLZdeazxmrz Hi5qsDjz8onZc+ELxkcTLWReY/0+IgW07oI7Weuhu04zI/wz1akwAb98KcN5kHaQsKZr+TqHql 8aztcFzfstEbQz1SI09/A195ZzxzGSljLTuoV6A0mXdDFX/5L89BI0ZNDF32VaRfqr1IQ6Ek1w 3zrwJTC6Dlzhui/VCKTRyoN5xPohbqGJrwTVaO1glwndm0DDKn3xZtkugbrJ/HScsNyxuJIrn+ j+c=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06/07/2021 13:58, Olaf Hering wrote:
> Am Tue, 6 Jul 2021 12:23:32 +0100
> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>
>> + count = stats.dirty_count;
> Is this accurate?
The live loop relies on it, and it worked correctly the last time I
tested it.
> I remember the reporting is broken since a while, and testing a busy domU
> indicates it is still the case.
If its broken, it needs fixing.
> # xen-logdirty `xl domid domU`
> 0: faults= 0 dirty= 258050
> 1: faults= 0 dirty= 257817
> 2: faults= 0 dirty= 253713
> 3: faults= 0 dirty= 253197
> 4: faults= 0 dirty= 255154
> 5: faults= 0 dirty= 260876
> 6: faults= 0 dirty= 259083
> 7: faults= 0 dirty= 253163
> 8: faults= 0 dirty= 258349
> 9: faults= 0 dirty= 260330
> 10: faults= 0 dirty= 259754
> 11: faults= 0 dirty= 257273
> 12: faults= 0 dirty= 255756
> 13: faults= 0 dirty= 258209
> 14: faults= 0 dirty= 257847
> 15: faults= 0 dirty= 59639
> 16: faults= 0 dirty= 81
> 17: faults= 0 dirty= 86
> 18: faults= 0 dirty= 111
> 19: faults= 0 dirty= 81
> 20: faults= 0 dirty= 80
What is this showing, other than (unsurprisingly) faults doesn't work
for an HVM guest?
~Andrew
|
