[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] tools/migration: Fix potential overflow in send_checkpoint_dirty_pfn_list()


  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 6 Jul 2021 14:22:58 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dYOhxNok8oB7UbiPy3NMo9UxyT4ijQTaPd5J4FhASV0=; b=UBNqGEv1OMckdEUzCeVXKJmcm2a1ZyvQoMRQGHp2MjiBkg6ZJ8ihZuIr6j/f8Y7/K7Lh1OSXifE5CJ+EUWTGo+2pMDR5JTVueMiARcF6gylr+NgtHwJjpHkg1n0ACy2i1nRk/4a/JmRhfJVVkQnOFPtW+OsDLuVp7aro5S6a6F6ucRQDYdHhjgESTF2QOpNFPJE1GKtU/hYIGuR4oX9pQNdTTImEeCKcgxfXxQ4/9JRE2ifpiEgLsXJCykj0j0Grnl312mzLOp/RPJfMH3QsSSWFYZHRLC42c6ESfdILwq8D6V4OOa/VtT/G8BPnWOUx5uSqzRpGQPZXD+yFs8HJRA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FmD5nORtwbHfiAcslYkFRSFXsZzxwFtE1larFwUDU1Ca5m3F9Y+cX8ilnLt4sVEJIRdCMyEtGNGFrjz78aSRO1a88s5YtxLSYIQtRlnJHkz47CumzV9zgcWfD67+zkedQFLnQd5IQ2Wi3jYQTpLrjVF2qb52y7HTitehRr4w0AsmNCDdB3TRu07r62DL9I8gGWMfaNUxVddJnUj/7W9aIHMCsR86rpu52IzNG1GAeEYySAx5Fe80iXsZbAWo1XAGxVHhXHvSWmCoavIXbni283fswSTGSw0lfI7j6rYkCwoIxCfpGbCJS9lG5Rq+RjfaunUS1epryvtsxWF632MZ2Q==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 13:23:13 +0000
  • Ironport-hdrordr: A9a23:RpOVLKlXFuZnnDX9kDIIN6ZiNiLpDfLz3DAbv31ZSRFFG/Fw9/ rCoB19726RtN9xYgBEpTnkAsO9qBznmqKdjbN+AV7AZniFhILLFuFfBOLZqlWNJ8SXzIVgPM xbAstD4bPLbGSTjazBkXOF+9RL+qj7zEiq792us0uEVWtRGsZdB58SMHfhLqVxLjM2Y6bQRP Knl7N6TyPLQwVuUviG
  • Ironport-sdr: zTe+4uoOoTx0P2r+k0+741ZnJiSH0fP8t8JYK6wQyn3oLGYCYF2i9HCR8S2VHQPQe6d/umjeNU 2A5Hliz3eC6RvKgTQENllH4IdXzMijH47HqDD0G+rFjFw0FCvIGxOnt/PMgfsK0zhm0rdNVSgo VHBSZmYTnPXczZem0IrweN3DH0JttQvURAyZU0TDcw6iwI/H0Ml3dIrhS7dDmaSbnCJwLFaU70 oZ7oNMOdOquvHNHRya4V/jtGP+/OQHqSziQBuiaj8OFLpTXXuLpcAoACeaDZFoGC8R5lwWBXF3 ZeM=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06/07/2021 14:19, Andrew Cooper wrote:
> On 06/07/2021 13:58, Olaf Hering wrote:
>> Am Tue, 6 Jul 2021 12:23:32 +0100
>> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>>
>>> +    count = stats.dirty_count;
>> Is this accurate?
> The live loop relies on it, and it worked correctly the last time I
> tested it.
>
>> I remember the reporting is broken since a while, and testing a busy domU 
>> indicates it is still the case.
> If its broken, it needs fixing.
>
>> # xen-logdirty `xl domid domU`
>> 0: faults= 0 dirty= 258050
>> 1: faults= 0 dirty= 257817
>> 2: faults= 0 dirty= 253713
>> 3: faults= 0 dirty= 253197
>> 4: faults= 0 dirty= 255154
>> 5: faults= 0 dirty= 260876
>> 6: faults= 0 dirty= 259083
>> 7: faults= 0 dirty= 253163
>> 8: faults= 0 dirty= 258349
>> 9: faults= 0 dirty= 260330
>> 10: faults= 0 dirty= 259754
>> 11: faults= 0 dirty= 257273
>> 12: faults= 0 dirty= 255756
>> 13: faults= 0 dirty= 258209
>> 14: faults= 0 dirty= 257847
>> 15: faults= 0 dirty= 59639
>> 16: faults= 0 dirty= 81
>> 17: faults= 0 dirty= 86
>> 18: faults= 0 dirty= 111
>> 19: faults= 0 dirty= 81
>> 20: faults= 0 dirty= 80
> What is this showing, other than (unsurprisingly) faults doesn't work
> for an HVM guest?

Sorry - I meant HAP guest.

What hardware is this on?  i.e. is the Page Modification Logging feature
in use?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.