[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 7 Jul 2021 10:19:57 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+FTMHFD1RoYL5CmN4L4VOuAQCePYv4TCiZzsGfakQJ0=; b=PES9280cHRlcxXguWKUzNy3j3z4RHptlevm0Zje52mvGx2zAH2hpO8ZTacD9nTfUvDm74ZtbAXL10G3fho0IuJ2ewXIex3qAzokeZGipbAzDlQfONA834FOCLQYnXWcmDcU41NA3ptQ2Z9Ttm8j8UCP0JKi9dff16HT5D/cDJt0AGZkJ0wvBs4To86HyOxb6A3MGMK+b6ALIIJuFnPnHceKJJvQBfbSAa+LEgBcGwn7ryZTj1swyA92i85AOU6/h6dCROWMzaXstuX0mSucInOctCf5d2KUK16KBZVKekF7F883NPr6QL8rFaRe6ldlSceaH1FuSTjqEXv6Ho21vvw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGXbgSef0JOG33UNVBuH0UE9Ap6IUIez52Cq48XyR0YOk8uSEHNiRyV7kkrF3NkLh3Z6uU70gPk6wTRr1IImDGOCaSsmeSCF3cecD8ko848BCt5nvFiNNMWP+Aifx1WD3jv53J8jUMU3p/S2bHLNT+VcIvilNWdVGvr7Ht4EEVzjaHd/3GsvQAgJagLx7M+DVA0IphpZfVvhoevxLs59V4aQe4qErdwZfnePe8W9xMWuA/dGEfd58aMB88OW3ppIUgBJf46UT6yWHJYEzpQifHv6x8scDwoPqFWSIuVVY71orWwousRPB+hxhjKnLMyrzpi+B+n32Tv6e1oMGUde6A==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <iwj@xxxxxxxxxxxxxx>, <wl@xxxxxxx>, <george.dunlap@xxxxxxxxxx>, <julien@xxxxxxx>, <sstabellini@xxxxxxxxxx>, <jgross@xxxxxxxx>, <christian.lindig@xxxxxxxxxx>, <dave@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 07 Jul 2021 09:20:17 +0000
  • Ironport-hdrordr: A9a23:vDrVFKuRTWoEUbXNij2daIDe7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
  • Ironport-sdr: cGpv1Ff2vhUNJRdV/njLrvXtShothn+oHQheEfrvSN9ieCrmgPUJFfbUEr5kIYLoVx2PBdwyiH 1jtx4lJeha0n+nw180rS2ukw2LWYuL0wPkiYqSzL6HEBNg9JJYV0b4+SnUo30VYSBRD6MRNp13 5atfgZErQxMZOzlgvd9E8cznn+srFC7DaTJJFirlV72lAlPzHjBBcgwjdKvlzIq9d/+PMM3rWI N/qhnyh7/f8AhcyfOISQohhHuhOnt3FTp4NszzJWa9C7wQ0sHhX0/IONwMugGmi4f+3syW1akp 8GY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07/07/2021 08:46, Jan Beulich wrote:
>> --- a/tools/include/xenctrl.h
>> +++ b/tools/include/xenctrl.h
>> @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch,
>>  
>>  int xc_domain_irq_permission(xc_interface *xch,
>>                               uint32_t domid,
>> -                             uint8_t pirq,
>> +                             uint32_t pirq,
>>                               uint8_t allow_access);
> Take the opportunity and also change "allow_access" to bool? Or is
> use of bool prohibited in external interfaces?

We've got bool's in the interface already.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.