[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • Date: Thu, 8 Jul 2021 02:08:33 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yefzc+M5i2H0lPr8iW9RedBY/KC1AATX6LXYLMhRrQ8=; b=IH/InWHQC+FBTxtTQj7GfsIfRyxQcYImRUMJXBSqVJmR2P45X8cWC5mO6avEP888l3aQpwDocIzNJFgyGyG98jMkc/v+iWBwi1wzNJ2fnoANwJ3o7Z6Xi+mE/QScZOxld2svbP8eAmANORzinvFrcYXiHe5GlcHO1xy98/m8GBpZ5f8pTDOjAJlKI1sdFbUGtv2J2d8Z2ycc7eKARmuTZBER469ewhcP/Qfg/gU1zIZP07TgXVZyEboZti3BPMERxOWNT2IKwMk8oBPcOF5WqlSKY0M32h0moyffw3BpRCHkF4xC2xx//3MLDAlfXp+7EfSMZW0UqQ70lOKzgwEpGA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQA6k4ZAkPXuwQVMUuBSxWiMl1rbRUYhMhf7+twQ+xrKUIq+z9bleJOUhyx/DBR4rzCHBNejjyNzH2Nf6K3hB4sKqFbXQHu7doqvhIwRrjde9a59X8s47C8kC8naTrJ5y/tYy0cZrW98zThkpbNdkd8cb/smYiaMfKE/FcSUwGP7K9ktf66168HEMjidNAKOD8B/2D+T9X6ED1qIplMs/aIenH1qP+h3M5vOxhE300Ypl62UiU0sBsFiUIcle4AaCHNXE6Z39E5FNBXVDKHAozWw0fpDMVoRJNPZ+f65hMC9pFxX2F5MND2EzxUEMv3D/xfAfFfLo0JWi3a7uAEP5w==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <iwj@xxxxxxxxxxxxxx>, <wl@xxxxxxx>, <george.dunlap@xxxxxxxxxx>, <julien@xxxxxxx>, <sstabellini@xxxxxxxxxx>, <jgross@xxxxxxxx>, <christian.lindig@xxxxxxxxxx>, <dave@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 08 Jul 2021 01:08:53 +0000
  • Ironport-hdrordr: A9a23:6ksd1Kzt/GV12EiN+zeNKrPw1r1zdoMgy1knxilNoHxuH/BwWf rPoB17726RtN91YhsdcL+7V5VoLUmzyXcX2/h1AV7BZniEhILAFugLgbcKqweKJ8SUzJ8+6U 4PSclD4N2bNykGsS75ijPIb+rJFrO8gd+VbeS19QYScelzAZsQiDuQkmygYzZLrA8tP+teKL OsovBpihCHYnotYsGyFhA+LpL+T42iruOeXfYebSRXkDWzsQ==
  • Ironport-sdr: gRLGubRZMug6oBsh+HeLZHZAD2xSCFuRfFqlGpjkMcHZFza6sGOLPKebk+IyuCzYLP03zwjBox VZzqMeCNX8Pk//yN3I/9IS8dHN2hav2GMUM55lgZVpy8p9RR1BgyW3xgxPoorLrq6WgYZSUYfY bZsQ3nuK2otW7+KIK6Tz0cguX03jAvhHFGscf7tDa5LpIfyshdz3Yl5LxRElOpEcYjwNm0mVWZ U2ekvbKF/HdfUrXkS2rFJHVnvp3LZIbEl8Nvb/HmKDXD91GuQW/LsnKRyFKOvj84Ir2uvdKTTF 6xk=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07/07/2021 10:19, Andrew Cooper wrote:
On 07/07/2021 08:46, Jan Beulich wrote:
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch,
int xc_domain_irq_permission(xc_interface *xch,
                               uint32_t domid,
-                             uint8_t pirq,
+                             uint32_t pirq,
                               uint8_t allow_access);
Take the opportunity and also change "allow_access" to bool? Or is
use of bool prohibited in external interfaces?

We've got bool's in the interface already.

Where exactly? I couldn't find a single "bool".

Igor



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.