[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 11/31] build: fix clean targets when subdir-y is used

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Jul 2021 17:15:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bCMC93upXs5jkb+MXGY8aI8pAPWSEWwdjnJOdQ5TQao=; b=l5viSsJO5te6AkixuehD1paasCoO/1EyGO7Xj7h0MGfYCuq9JUk28EaHT5NdPt99nesX4RyyuDaBumYTj6S4kY/8xeYiiDIB2+7u1bJkBXrlXR2mri9sPk+YSNteA7LbcN2LEoyV2OSrF2nheC8Mwe9Ak5bolOrz+GCHURi6WM9Qq7TDRZMWYEQLS4eH+ZdNTTQ0JMz1Tf6LngMc2klImFDlODDxlOaCAZVqxEI0irjzrufD2aXSrdtgwXP9loce5bGwzv0A73LyAKeKV4cXqnD9iz28y/Ewel2Phg0JCSw9C2uSc9n9OGRcvjlG3o6m8UiuPM6x52b9yXWH0duAOQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOrNzu+tThMZYuw8bzScnjtHuPEwWKbXjO8C2B5FM2LjlU+TfcMKmUWDM0FaZyB8FwLo9oYoaF/k5nzdXCjBXlDdReJDo2MZQFkBQNYljdoai8nbMHFFYeJcU3KoxjxTuHEE5aNkgq2CZiV2V1WnhCKDCCz1pgQ4CZOMuLoL5T3w+iZYnjPBV/4ZAXYbZOZvXHMsBSHXXDJxxB6hBr4QTQBmSJ1Jbo8Q5QBhKZsJGOSbKH+tJi73LYsPpbMD2d0TUNtDmOxlZlx+qC7mRJ13djdz1k+EqaCVJO58Kdhh/Ld8Z5YsO7+O23UVVrPY9jUMQKvhqtjHlYmqTti1uzxavQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Jul 2021 15:16:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.07.2021 16:09, Anthony PERARD wrote:
> The make variable $(subdir-y) isn't used yet but will be in a
> following patch. Anything in $(subdir-y) doesn't to have a '/' as
> suffix as we already now it's a directory.
> Rework the rules so that it doesn't matter whether there is a '/' or
> not. It also mimic more closely to the way Linux's Kbuild descend in
> subdirectories.
> FORCE phony target isn't needed anymore running clean, so it can be
> removed.
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/scripts/Makefile.clean
> +++ b/xen/scripts/Makefile.clean
> @@ -12,19 +12,18 @@ include Makefile
>  # Figure out what we need to clean from the various variables
>  # ==========================================================================
>  subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \
> -              $(filter %/, $(obj-y) $(obj-n) $(obj-))
> +              $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-)))

Isn't this a normalization which also wants doing in xen/Rules.mk for
subdir-y? Or perhaps this is part of one of the subsequent patches




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.