[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 12/31] build: use subdir-y in test/Makefile


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Jul 2021 17:26:13 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yPUGnd18QU02VmAyYX8VKIkXFpSfM89yLNPUejSeJY0=; b=G4t+MpgnBzhMnASCag1mdj3rmXYhkJ14yVtJyMp3nIit2uqGAUm+LEHIkjh1Q5tF3ZtvTU4vrzSDMAnxvYg7hCmXdKbJ1pp+1rcJxadj9N8fpQvV1PUeyhXyZ7jP+d1dhokGoSiWEY00N64KB0Ehu7dE8g1m0dIC3RutBHNaQE8Xy9Xaf3W7iDv19pXjXDlJtdVrhPneG8BZQ9hNzL0YctOpVyQ6orMhMRYG0u30sTWEkeQGR/u9Bxpzne3cEcpffCwUY/kwMq28nj7aGzlivs4eMciob78qWbVL01gqhqAZMkCa0HzthEF07cdwvn888xDMGuVf8370DTrlzcJZjw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjD8RP9gPM6aB/yj0Dkh2G7u0Iuo4webf4uLTN4vnPwe1iqSU4kveHBZJo8e3mjwyEBYW4G8IZIxOJbH9NTNctz+iMjf4Dgszir0iQLZv/lsIMWF41zNidjGgA4zzkWdppUBo+cthsuKDjXIdV5ozvYSDr4O93dZf5XSmMpoF+6Tq4d7Q6wEv7C3lNjgChFYxYC+JGN+KLvK23utqNSPbl+YCjJBAH0p0OCS7uPnbsw/FXmUMoM0gRjOiVeBqVQ9IOnsUnSu84JxOHBMEuPF2Rnq7NGdsS0eTlqB82nfhXVI4uNvIehCa3DxFT+DYTgkkB8pq+hfprMiwSw5xDcmpQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Jul 2021 15:26:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.07.2021 16:09, Anthony PERARD wrote:
> --- a/xen/test/Makefile
> +++ b/xen/test/Makefile
> @@ -4,15 +4,10 @@ tests all: build
>  
>  ifneq ($(XEN_TARGET_ARCH),x86_32)
>  # Xen 32-bit x86 hypervisor no longer supported, so has no test livepatches
> -SUBDIRS += livepatch
> +subdir-y += livepatch
>  endif

As per xen/Rules.mk having

subdir-y := $(subdir-y) $(filter %/, $(obj-y))
obj-y    := $(patsubst %/, %/built_in.o, $(obj-y))
...
subdir-obj-y := $(filter %/built_in.o, $(obj-y))

this will result in building of livepatch/built_in.o afaict. Is
this an intended but benign side effect?

>  install build subtree-force-update uninstall: %:
> -     set -e; for s in $(SUBDIRS); do \
> +     set -e; for s in $(subdir-y); do \
>               $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $*; \
>       done
> -
> -clean::
> -     set -e; for s in $(SUBDIRS); do \
> -             $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $@; \
> -     done

And then why can't the generic recursion rule in xen/Rules.mk
not also be used for the "build" target? (I guess "install" and
"uninstall" need to remain separate, and don't think I know what
"subtree-force-update" is about.)

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.