[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 15/31] build: move make option changes check earlier

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 13 Jul 2021 09:42:02 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AI5fMCkaJ0OCgAepZ4TEXcCAhau8XZFddLb8uRA2ASI=; b=i2M/f6b1tGjNxvJ2dijfRzzZwEIK4oKnVi5l13oIwnxlayHw1PWfEsL4b6tKjCpksBEXPkjMbTcpyWnPmlF61jZjV/SOdaez+3X7xei1uulIRog/ptvDkOwfZTvcZ15/s2gHI02jbJLrMbuLRebnb6mZA1zFYe888GGK290m2o3Zli/hzkSjJ9zk6XeY+we9I+fwLrru0MbJrC3sczVCfOQPHvesHRtPYmP85b6JRk88XvO2/R2qgn59z1zENTxZWvNmVeBsA2TKD/pYJGe2YDMH5Fgo+4t4+uLuCDMEbIPPwqjRt8zRfJZeJy3ac+HN3mFU498l1vx4Jf1e9zC8Vg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/L2zhSZMia+wfBPD3PrBbgw2VafJNoHWAhOM6XR4XPdKUsZZlmLYGJKSKwPLtO9dTTd6sQbGxkSLYcDy2w/JqnKZDiJvn2AArjl1mQxIy4cKqP2jL9igCZkTiXruDnzZcGVa4HTKydubUneFLx16MQp9sBpxTS7HtiiYONNQUOLiTh3BqOexaJeSlmiEH4eJQyVk+uHbIqfc/aRPv3R0F2/sVncMy4S6hor9qooc4/YyTncaIFW23fgGluP4n0l/39wgzLWZyvIPE/iDEaQBjZQ1+x/2YzazFFMqZNsndjEfwyUmgAVAgp2warL2NDY+rM9VtT7mHRsuaoAUKQIsw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 13 Jul 2021 07:42:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.07.2021 18:21, Anthony PERARD wrote:
> On Wed, Jul 07, 2021 at 05:40:02PM +0200, Jan Beulich wrote:
>> On 01.07.2021 16:09, Anthony PERARD wrote:
>>> And thus avoiding checking for those variable over and over again.
>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> in its present shape since all you do is move existing logic. But I
>> wonder if I could talk you into ...
>>> +ifneq ($(origin verbose),undefined)
>>> +$(error "You must use 'make menuconfig' to enable/disable verbose now.")
>>> +endif
>> ... doing away with the misleading mentioning of just "menuconfig" here.
>> There are various other *config targets, many of which are also suitable
>> for the purpose. Personally I've used menuconfig (in Linux) the last
>> time perhaps 15 years ago, and hence I have almost forgotten about its
>> existence. IOW at the very least I'd see us insert "e.g." everywhere.
> Hopefully, no one ever hits those error anymore, it's been 5 years it
> seems since the changes has been made.
> But I can write instead:
>     "You must use e.g. 'make menuconfig' to enable/disable verbose now."
> or maybe:
>     "You must use Kconfig with e.g. 'make menuconfig' to enable/disable 
> verbose now."
>     ?

Either would be fine with me, with a slight preference to the shorter




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.