[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 17/31] build: convert binfile use to if_changed

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 13 Jul 2021 09:51:45 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tJDyZWNz9UB8xi3a2Tl57QvZ9V91tU1yw0GrhIYiE1w=; b=IUbfzThG1rPG9QVlZT8oymtTKyEbiCc0+NshtnPVUsx6kXNDXYhjtXsjk6HOFhcyyxQ55auWZZ5/dwvbjeOhh0u7JR57eQBUh00By2xKeBWfaW57k88GsQDMW9VWK12xaYeA9WZukBV6/+a58LskcXJcJApfRwKdGblh3AvSFomxp0HU0T8AcJSrDzsDkpGmgcUTUCl1A8EEtMHaA3aFr8vpbvG992NVjXOZyEEzxFq9nCrexHsGcgDZAqqI4xOYyMKd/J27y5t2Ovk5HKxsdI47/n2TWTNfEJJ357UbGlu2pxH4veBOU8JPtpa1spi5EOV37t9cwXUOmdnfisk3LA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oBDKsfmjgTcAw+LUqmFVsLtVLgoSxydYf/L3Im/UGZUQfS23hLHX8dTXQW8Rvzrk5iMQ/5GV19qL16ecz3k3QNJd7Zcg+0COHvIvD09jI1p78YuYSELdXPE1gQVnXE1k3nbw4dpuL4R71H9Ll1Ox68DJow/MEQ0o1nnCqGUd9AVvjAbckaOoeJ0ipcgP6XOQGtzGhlyQbo0xUCVeLZ9IhX1Qb3QCfQqazkxX05DrNApOCwljsQT8Q6RlEePy2lI2wcMdIVWL1SIk9PDN/3uchUH9HIF9x/080jYgUBosclhzDVQuNFpvay1009llcrpOBgIPvxE67CcWN+iEq9K+Tg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 13 Jul 2021 07:51:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.07.2021 18:32, Anthony PERARD wrote:
> On Wed, Jul 07, 2021 at 05:48:57PM +0200, Jan Beulich wrote:
>> On 01.07.2021 16:09, Anthony PERARD wrote:
>>> --- a/xen/common/Makefile
>>> +++ b/xen/common/Makefile
>>> @@ -80,8 +80,12 @@ config.gz: $(CONF_FILE)
>>>  config_data.o: config.gz
>>> -config_data.S: $(BASEDIR)/tools/binfile
>>> -   $(SHELL) $(BASEDIR)/tools/binfile $@ config.gz xen_config_data
>>> +quiet_cmd_binfile = BINFILE $@
>>> +cmd_binfile = $(SHELL) $< $@ config.gz xen_config_data
>> This is an abuse of $< which I consider overly confusing:
>> $(BASEDIR)/tools/binfile is not the input file to the rule. Instead
>> the script generates an assembly file "out of thin air", with not
>> input files at all. The rule and ...
>>> +config_data.S: $(BASEDIR)/tools/binfile FORCE
>> ... dependency shouldn't give a different impression. What would
>> be nice (without having checked how difficult this might be) would
>> be if quiet_cmd_binfile and cmd_binfile could move to xen/Rules.mk
>> and merely be used from here (and the other location, where the
>> same concern obviously applies).
> I've though of having cmd_binfile in Rules.mk, but it's made more
> complicated by having a "-i" flag used in flask/.
> So one things I've writen was:
> config_data.S: $(BASEDIR)/tools/binfile FORCE
>        $(call if_changed,binfile,,config.gz xen_config_data)
> flask-policy.S: $(BASEDIR)/tools/binfile FORCE
>        $(call if_changed,binfile,-i,policy.bin xsm_flask_init_policy)
> with:
> cmd_binfile = $(SHELL) $(BASEDIR)/tools/binfile $(2) $@ $(3)
> I thought this would be confusing, so I avoid it.

Indeed that's why I did write "without having checked how difficult
this might be", because I definitely didn't want to suggest such
anomalies to get introduced. It's unhelpful that options have to
come first.

> But maybe with the lists of flags at the end, it would be better:
>    $(call if_changed,binfile,policy.bin xsm_flask_init_policy,-i)

Yes, this is a little better imo, but still not pretty.

> Still want to move cmd_binfile to Rules.mk?

I'd still like it to be moved, but without resulting in a rule
that's not consistent with others. Maybe we should have a
BINFILE_FLAGS variable (paralleling e.g. CFLAGS)?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.