[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v6 12/31] build: use subdir-y in test/Makefile


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 13 Jul 2021 15:35:22 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 13 Jul 2021 14:35:30 +0000
  • Ironport-hdrordr: A9a23:WbM86qMNgEhhZcBcTqKjsMiBIKoaSvp037BL7SBMoHluGfBw+P rCoB1273XJYVUqOU3I5+ruBEDoexq1yXcf2+Us1NmZMjXbhA==
  • Ironport-sdr: JoMCBYI15a+j4WB/zUlO/EGuzfPHYN2ZV6EFfZUWZn13E5bKRDvrvquwHyVYG7vji1TsOyy6s7 U+lDPSC10URGrbk498gCDkEogTIMMoaiiZh/Le0CiviOivSBS9LnDIZX9EAiIgVGp2a1oOzq4n FOy0Q4XSB8b/sewkK8ovSo9zNkTxilzKGhzdhovfEs051SxNtcwAaSuiYi+FV+JwjXwS/NC0pj wqqA/DtmbZ7USfunoiAHjbKdlMonydspkiYOcl2/U7Srido5jj9heG1IKpbMCOK/1Zn5aHYB4O ARA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jul 13, 2021 at 09:41:03AM +0200, Jan Beulich wrote:
> On 12.07.2021 17:22, Anthony PERARD wrote:
> > On Wed, Jul 07, 2021 at 05:26:13PM +0200, Jan Beulich wrote:
> >> On 01.07.2021 16:09, Anthony PERARD wrote:
> >>> --- a/xen/test/Makefile
> >>> +++ b/xen/test/Makefile
> >>> @@ -4,15 +4,10 @@ tests all: build
> >>>  
> >>>  ifneq ($(XEN_TARGET_ARCH),x86_32)
> >>>  # Xen 32-bit x86 hypervisor no longer supported, so has no test 
> >>> livepatches
> >>> -SUBDIRS += livepatch
> >>> +subdir-y += livepatch
> >>>  endif
> >>
> >> As per xen/Rules.mk having
> >>
> >> subdir-y := $(subdir-y) $(filter %/, $(obj-y))
> >> obj-y    := $(patsubst %/, %/built_in.o, $(obj-y))
> >> ...
> >> subdir-obj-y := $(filter %/built_in.o, $(obj-y))
> >>
> >> this will result in building of livepatch/built_in.o afaict. Is
> >> this an intended but benign side effect?
> > 
> > Actually, nothing in Rules.mk is using $(subdir-y) other than updating
> > it with possible subdir from $(obj-y).
> > Recursion into a subdir only happen if it is listed in $(obj-y) and thus
> > should be part of a built_in.o. Rules.mk doesn't have a mean to recurs
> > otherwise.
> > 
> > So nothing is actually going to try to build livepatch/build_in.o due to
> > $(subdir-y).
> 
> Question then is: Isn't this actually a bug?

No, "obj-y += livepatch/" need to be used instead, to build 
"livepatch/built_in.o".
Because "$(obj-y)" are objects to be included in a "built_in.o".

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.