[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.13] x86/tsx: Fix backport of "x86/cpuid: Rework HLE and RTM handling"


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 15 Jul 2021 17:39:01 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TQumDl358wnlOJ6NniYm7wz+OqmoJIGghw42t0U/zEo=; b=BLsfcweAT1B+8RVrJUEpW0hJ6mNliDHS59YLt1w8O3SVeFmMqn0d12yPxUzNAuuNDkzIh22As2jpMdJeYYlfl48J1OAzIzaeLnH1Ol0alzzFqwUVO2TQ1e0abEvhi6JIi8Q7fcW6oZCTBEfQ/puu9KWCfPCSnToNCL8pBi7C2NImCevqdl0inU4Gmoz2uIa0G18Zn+QRBH23bUmAj8h88tbIg/YfR+c7V6H+WRdf5fOxoLDKsM3Y0xXzUaQwyE4xper4LTl7Z1/+MQPoUcVt6Hz753Gh7EHf4etd2lbxVZKHFndzfYPlKfeggFL0nIvfs4x4bBbEH3It4ct5GnYS7g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mrlvd8uUMUC9jbSTcB560LeoHQArMRxJUSabRF8Sx1KQRWoPdt8PSzPOdqxzmeLJ9CXoAU25KEj1SzAtaxYgn2x6n9kNpNp9wp4lZxTFAsKYFIX98dxdrbxiPoBcnkGpQHTwCXJ/ibU0goJoDNa70waZkR9E6BGG99jk/dkFyRvTu0q0ynQmI/jBfRonWHlkNRI2AFWlsCEnNalx5E/0p24yZmxS7LeBasnKEjL4rU0PPG0VMcy+KOQz136ENgQ5Zzlwsm+8HEV+wPPyJFgdiTmMnEnCQ7D1SmARySebhe3L7qeWuHLxauFYRbJ9o96OsM3xl7d75KFSJGw7cWz3iQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 15 Jul 2021 15:39:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.07.2021 17:10, Andrew Cooper wrote:
> The backport dropped the hunk deleting the setup_clear_cpu_cap() for HLE/RTM,
> but retained the hunk adding setup_force_cpu_cap().
> 
> Calling both force and clear on the same feature elicits an error, and clear
> takes precedence,

Right, I particularly didn't pay attention to this interaction
aspect.

> which breaks the part of the bufix which makes migration
> from older versions of Xen function safely for VMs using TSX.
> 
> Fixes: f17d848c4caa ("x86/cpuid: Rework HLE and RTM handling")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Are you going to put this in, or should I?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.