[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.13] x86/tsx: Fix backport of "x86/cpuid: Rework HLE and RTM handling"
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 15 Jul 2021 16:56:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PrDK787t7B1TC3mV8QTu5tx07cSczD8SSlGhA44DLCk=; b=lvqPLY9bjD1q1QCKLuO/FwCQRozwot/m4Mr7uRBYEGzqz0pT8P04fMLN5F2Ypgz84Z8fWYyeeq+n6/XZjCIrMAACjpA/CKfzOUHBYBGQ441jGOGYnl46U0je1GLXUomGi7GencYFg5OlekzomeqKAUQ45L1g63sC27xgAIHG6U2FcTRiO2HTwSukyQoN1v1zghRYrEMYFxbAXo9LNxr5hRjMIFNd02AR3LFUzsYCASqBSS5I3lbfuS2KV9hWkP13wDGFHHWsTY/ESJEcjg6eWQW4eQviJIrmWALit+9s0qQlnvtsL4DMEgV8Sl8dPYbbw0BH8R3PGSK28cdIn55iNA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a543HI7Qs8QZf1F+8Stc5hew4pqKpRPaxUaGhrFEaegWGJ9RDuM3tUldBwOL+czO1T0zfqF2b2p5pwIEwKQCxZdgvmn9VcLhJwfUAphMt2Kl5jeWPhji2wv1Mp7KIHl/uYdStcqbiRD+nzprDQ5K9whc8I9H1krkjRJTwNgTjIr0bABO9KEVnBPbg+l3SXw8EhMzE83QeCQnSabvbqEdFNGtG/yYNzDoGTactilbeSnBtE87Nfbc2bHS+zlD8T+CyzX/7rAqh5c0iUFBEHSjkoy2ZBN0XZqbo+0xjbiUamCWuNdil0STBruJzRYea/Up5KJIReNBNMyWmkFf3YZxgg==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 15 Jul 2021 15:56:24 +0000
- Ironport-hdrordr: A9a23:fquY6KvAnXyqK4buF0qVojsK7skC34Mji2hC6mlwRA09TyXGra 6TdaUguiMc1gx8ZJh5o6H8BEGBKUmskKKdkrNhQYtKPTOW91dAQ7sSlLcKrweQeBEWs9Qtr5 uIEJIORuEYb2IK9foSiTPQe71LrbjmzEnrv5ak854Ed3AzV0gK1XYcNu/vKDwReOAwP+tfKH Pz3LskmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgDfIBej8AXeSIrCNWkH40Yqv/MCTvKR0TtQgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59Zs5Vza/pWVFZql/1WwKqVKuZ0IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkaoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWsKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnief/FmHKc7hSwlZV/NEQgF5vsulKSRi4eMMIYDaxfzOGzGu/HQ0ckiPg==
- Ironport-sdr: H5ByvFTQsttoskjMB9FNVnMmdwKgvjIs/R8RJX812u4QnYnSYzGAiZqllT22xPZ1ux78OUQhF+ 4uwyplWm9lF+Txjq7Kr9IV226naWKVc6Wc+dl4w1yMG2BDbhiyzrPpDV290kbcrhRZIfSHFC7n tcFDyMRCKFAxvB8w2lkKPsWrzpyg5IhrKzDQBevbqC8eiyMaGv3SC0kVImf0IQ5wMbLqGf683O 3LnjB4HUQcTMje9nFIOc1wvZvz5IMZPkzw5WYQDgqfyz2EpD38WFj0DNkXKTNLPEsqKACqH4yB 2tY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/07/2021 16:39, Jan Beulich wrote:
> On 15.07.2021 17:10, Andrew Cooper wrote:
>> The backport dropped the hunk deleting the setup_clear_cpu_cap() for HLE/RTM,
>> but retained the hunk adding setup_force_cpu_cap().
>>
>> Calling both force and clear on the same feature elicits an error, and clear
>> takes precedence,
> Right, I particularly didn't pay attention to this interaction
> aspect.
>
>> which breaks the part of the bufix which makes migration
>> from older versions of Xen function safely for VMs using TSX.
>>
>> Fixes: f17d848c4caa ("x86/cpuid: Rework HLE and RTM handling")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.
> Are you going to put this in, or should I?
Feel free to.
~Andrew
|
