[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG


On 15/07/2021 16:18, Jan Beulich wrote:
On 14.07.2021 22:37, Bobby Eshleman wrote:
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -16,6 +16,7 @@
   * GNU General Public License for more details.
+#include <xen/debugger.h>

I don't think this is needed here; instead I think ...

@@ -41,7 +42,6 @@
  #include <asm/acpi.h>
  #include <asm/cpuerrata.h>
  #include <asm/cpufeature.h>
-#include <asm/debugger.h>

... this wants to be done in patch 1 already.

+1. I was actually going to ask in patch 1 to drop <asm/debugger.h> as there should be no more callers of the debugger helpers.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.