[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/10] xsm: expand the function related macros in dummy.h

  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 16 Jul 2021 09:34:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WeBT2B+0DO4WfpakyKBnw75OOhwBBh/evF99g3h3TOk=; b=AV6C6+lbrDtIlanVRIq1dGNGP5jjeTTjrhOHhkxa56vydtyuW6Elz1k4QP7Oqkak9lInIRonU6ALqO7R7aSZ+UDRFMhViRiKV3551qf3QxAnapKbRvHqYQITXL+aGw7JaLvg3quuMcesw8XlCZluES/V4+Wqe1rZoRLM9KViAuB5cj/gXLEx+G51OzB7i9LhG5lqNpEyrSWT4Eky87M3kqlvkHPqIs5nWJ374R1WOiPu5P0DmrbWu8SDg0uo4dABgl82bKMUULFsfPlJ/vWwQH7kH8bjfnMDlQRHXpr8dkvt6cTBpjygFloQlvVDSAcN7p4N/OQjdkrviBI9v7ldbA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JICVJB6fgHHskJZTohKpIEeN5mLDCPOP+qfa4ArV2hllybn66/dG11RpwN8xeMZ4/D2fVacciG4Eb/R48m5PwtyVi32LlTO9kqcOchpkH49w3MHgy/Z3aMgeqME9mJS7ylS6id9hy8IVY18ebmy2Ki0xVSAkwj4JDuga7HCDMqxbyqcLaS9z8VN1EUrdB2qkFHVf5TsJkOqIpuqPubDmhx4y00LFBZ5d9QZoTsMi71b9Coge7XvECgPXtWPZEPwzQUrR0hJ/sg9zYAIsxzHsHrUQqpY20ldYmMQ31ZYD1BXjvtzT5ZzZ2n3bUAAT/AHSfWONFk6Jo/cvYfWouxbc8g==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 16 Jul 2021 07:35:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.07.2021 22:32, Daniel P. Smith wrote:
> With the elimination of switching how dummy.h gets included, the function
> declaration macros are no longer necessary. This commit expands them out to 
> the
> only value for which they will ever be set. This results in function
> declaration lengths changing and since some definitions did not even follow 
> the
> 80 column wrapping style, all function definitions were aligned with the
> predominate style found in core hypervisor code.

I'm afraid this last half sentence is quite far from true:

> @@ -82,43 +79,43 @@ static always_inline int xsm_default_action(
>      }
>  }
> -static XSM_INLINE void dummy_security_domaininfo(struct domain *d,
> +static inline void dummy_security_domaininfo(struct domain *d,
>                                      struct xen_domctl_getdomaininfo *info)

Padding wasn't good here before, but you clearly do not change it to
either of the forms we agreed on as being the goal for consistency:

static inline void dummy_security_domaininfo(struct domain *d,
                                             struct xen_domctl_getdomaininfo 


static inline void dummy_security_domaininfo(
    struct domain *d,
    struct xen_domctl_getdomaininfo *info)

. Further down there are enough other examples.

> -static XSM_INLINE int dummy_domain_create(XSM_DEFAULT_ARG struct domain *d, 
> u32 ssidref)
> +static inline int dummy_domain_create(struct domain *d, u32 ssidref)

When you have to touch lines anyway, may I suggest that you also take
the opportunity and convert u<N> to uint<N>_t, to bring this file
better in line with ./CODING_STYLE?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.