[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/10] xsm: expand the function related macros in dummy.h

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Sat, 24 Jul 2021 16:43:04 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627159386; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=l0HQ0dv2xeoNzvlSu1aIz5cr2FnCBz+hT2qxMfZWAmE=; b=E6A114aSfHPZBZXxGEyt/UOR5km4iEHpMVse+gRSLW4YHRcByfx5kRJu0LF/K9f2GOq2yjwW8LbcO0/VOMQ4dmQC7Cduk8uS+tYMJxmMS8jObSJuirWlrkimmZoKdr9plqwSOJfXOyxEFe+bzqC097bnNEqbMcmagt7O95A9+fQ=
  • Arc-seal: i=1; a=rsa-sha256; t=1627159386; cv=none; d=zohomail.com; s=zohoarc; b=Sn3MFxVvSMGzV40V3JczanAvqsAaYMpBM/Mm0SWAIfEc99rOMHew5Y2698SZD25SmzpxlDXpehDA8NuDoYukTJ/GktpkxVIzFAkyLED4e9FCVGVvMD6ktbfVJ6om3rS88WgyzILvRJy+mK8JdTRcYZilomyFFyFiyuO3KUvuy84=
  • Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Sat, 24 Jul 2021 20:43:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 7/24/21 4:07 PM, Daniel P. Smith wrote:
> On 7/16/21 3:34 AM, Jan Beulich wrote:
>> On 12.07.2021 22:32, Daniel P. Smith wrote:
>>> With the elimination of switching how dummy.h gets included, the function
>>> declaration macros are no longer necessary. This commit expands them out to 
>>> the
>>> only value for which they will ever be set. This results in function
>>> declaration lengths changing and since some definitions did not even follow 
>>> the
>>> 80 column wrapping style, all function definitions were aligned with the
>>> predominate style found in core hypervisor code.
>> I'm afraid this last half sentence is quite far from true:
> I would disagree since I know I went through the frustration of trying
> to find a discernible consistency in the files in common/ in the end I
> settled on following common/memory.c since it seemed to have the most
> uniform, it had only a couple of anomalies, as opposed to other files
> where indentation was varied throughout.

Going back into the patch I found what happened. I am not sure how, but
every parameter line I wrapped had 7 additional spaces. This has been




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.