Re: [PATCH] tools/libxl: add missing blank in message

[Juergen Gross <jgross@xxxxxxxx>]

On 23.07.21 12:23, Alan Robinson wrote:
> From: Alan Robinson <alan.robinson@xxxxxxxxxxx>
>
> Add trailing blank to first part of concatenated string giving
> "an emulated" instead of "anemulated".
>
> Signed-off-by: Alan Robinson <alan.robinson@xxxxxxxxxxx>
> ---
>   tools/libs/light/libxl_dm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
> index dbd3c7f278..755641604a 100644
> --- a/tools/libs/light/libxl_dm.c
> +++ b/tools/libs/light/libxl_dm.c
> @@ -1893,7 +1893,7 @@ static int libxl__build_device_model_args_new(libxl__gc 
> *gc,
>                   if (format == NULL) {
>                       LOGD(WARN, guest_domid,
>                            "Unable to determine disk image format: %s\n"
> -                         "Disk will be available via PV drivers but not as an"
> +                         "Disk will be available via PV drivers but not as an "
>                            "emulated disk.",
I'd rather have a longer line without splitting the message (splitting
after the '\n' is fine, of course). This will make it easier to find the
coding emitting the message when searching for the whole printed line.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature