[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxl: add missing blank in message



Juergen Gross writes ("Re: [PATCH] tools/libxl: add missing blank in message"):
> On 23.07.21 12:23, Alan Robinson wrote:
> > From: Alan Robinson <alan.robinson@xxxxxxxxxxx>
> > 
> > Add trailing blank to first part of concatenated string giving
> > "an emulated" instead of "anemulated".

Alan, thanks:

Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

and queued.

> > -                         "Disk will be available via PV drivers but not as 
> > an"
> > +                         "Disk will be available via PV drivers but not as 
> > an "
> >                            "emulated disk.",
> 
> I'd rather have a longer line without splitting the message (splitting
> after the '\n' is fine, of course). This will make it easier to find the
> coding emitting the message when searching for the whole printed line.

I would be fine with this, and I can see how it is an improvement.
However, Alan's patch is a step in the right direction so should go in
right away.

Ian.




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.