[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] x86/ioapic: Remove use of TRUE/FALSE


  • To: Kevin Stefanov <kevin.stefanov@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 11 Aug 2021 08:16:40 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vtf+G9h18jZ0Ox4t/rWCng9TsUpKErcqgvQ4mj1kl48=; b=hgmUaV5OEAyem7hJ8ZdjHKK2vqNlXSIz414uG0u7UL1SoerhE+vvXuCroTZbhEk0iRzV/3OjFkH3oKqgt1ZSpfXHoE9OEpE2lPS07ZQ5j4ddkJuUPrIPEbLk79+Mn4YG+Aqe3GGrG4CSX6G87v3UrgML3DCKl1V+/93paXJYXZ83Rfa9ffeLe7uuAsR9oWmcy/pi44q1caGwU2cfHEpII1cNWqaSQwGxZl6VlRjDxd+7tt+0Stap5ktg2nxEiaf5EOZldcmC/0PR7CsuVCAtICd0TnTM/h0fosvlKYsla1i8VTRo4P7Qog4TNLgwVE+QtoZyzKAxZeuVxSWhV+C6RA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKRsVzAggej5OU7Kyi+6/NQKtU5CpSmjWF0Txctr06AiO+uxNRTrs/Zt9GYNbMspwnF6IZov/kL0YJNODIe0yYXznusvHpZachTpeH/vcvbRNmkh3GPi1kG51EBrHZ4quYE367HOvvEifv1N6JhpXh84v9OanujxpUNe9cZ/iWo//HGvN8SHm8pat5y35s91gEPL9bJcHewpZ2jt3GF9J7LNF3SBS15pN/3fS2Pi5ZUd6J3qMeYa9APVvYWKcc7w+6vapiZebVLJ6Bv13bghFQBJazUpcQ4v1M3MG4eL1yyKNGl9vPqFS3VgeBoorYDd4+pwM84sGBQecP8V7qtF+A==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 11 Aug 2021 06:16:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10.08.2021 19:49, Kevin Stefanov wrote:
> Also fix stray usage in VT-d.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Kevin Stefanov <kevin.stefanov@xxxxxxxxxx>

May I ask that along with replacing TRUE (there's no instance of
FALSE that you replace, so you may want to adjust the title) you
also replace the uses of literal 0/1 passed to
{,__}ioapic_{read,write}_entry() while at this?

Thanks, Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.