[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/kexec: Remove use of TRUE/FALSE
- To: Kevin Stefanov <kevin.stefanov@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 11 Aug 2021 08:08:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qfSTDbDBpgjpIjsDKd2Q5YvULOfbX/n8xvDJH/w+7d0=; b=eASHQJlELnWpd9P1V6m3iy0PBTUVpLX3G+e/9MDPp4KuZGdu4wVNjJPm3yLYKRJB2xUs3laG+rbONt/HHtl//R9UJlhtlRmJGIFyYlSC9DuZDQzRb36bu9K2orujnb7VRqV2aqsEf9V2Y5gmtotD3Z8TGlhEogrwFcUahbT3IL3RNk+dIJAsPHIl4Q0U9UY0kdxVnpaRlaTUO3PXogOpLMHCZqrVnL3oo416bw8qA2EEBqGHpfj0c1lUFThxFcFn9vphJG4ZOLoJPrnzeihLl0hLEqC9t1zznoL0PD7KG7FBD0PWfiiXBmD+dttY1dXHo0FHeDzey4jogd+Fts7j7Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ks8Gs/XnpsikHTAuKZYoiipKpJ/FV0m4DXuseP4SeiaRa/v4CxfNzFZstsmOhlEV4ISD2YAHN24mdL48OVUJvdacJefVf3DbTwMACkf/4+UBhpoFu/iP+QTJbPZR6BRHwy7+XpfzdnO9netLvaNo5oStIGhJA29qmQQtIXYJxnRRKc4rDwfDeWJ7w+YmFq4TEUb/tTD2GuIw1jGiG65xvB1mDAdzGM75uZObh0VdOoKBOntd2AgzVl3PKIh/UkTAIFsoLW5weGS6XgRLXqwM6gC1R91eIdhKMvnJ5c8fy4Z2U0+A5YSJ/9Ad7cswedFV1Vc1PQiRjtC/3T080x0vbA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 11 Aug 2021 06:09:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.08.2021 19:47, Kevin Stefanov wrote:
> --- a/xen/common/kexec.c
> +++ b/xen/common/kexec.c
> @@ -35,7 +35,7 @@
> #include <compat/kexec.h>
> #endif
>
> -bool_t kexecing = FALSE;
> +bool kexecing;
While not overly important for either of the two present readers,
I nevertheless wonder whether at this occasion the variable
couldn't also become __read_mostly. Andrew, thoughts?
> --- a/xen/include/xen/kexec.h
> +++ b/xen/include/xen/kexec.h
> @@ -17,7 +17,7 @@ typedef struct xen_kexec_reserve {
> extern xen_kexec_reserve_t kexec_crash_area;
> extern paddr_t kexec_crash_area_limit;
>
> -extern bool_t kexecing;
> +extern bool kexecing;
Later in this file there's also a #define of this identifier, which
imo then wants to also change from expanding to 0 to using "false".
With at least the latter adjustment (which personally I'd be fine
carrying out while committing, just like I would be for the earlier
suggestion, so long as you agree)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
