[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/kexec: Remove use of TRUE/FALSE
- To: Jan Beulich <jbeulich@xxxxxxxx>, Kevin Stefanov <kevin.stefanov@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 11 Aug 2021 09:16:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zI+Si/T6HhGUwGvoenX/9+kXhOBmrCtLoip7oz1VJhQ=; b=ZYKSHkzZ8aeHzVYLva5P450Y5bT7mTXHSIA1fDQVJKN1AR/mNSBQl7YfHRfBEmmzgnzZ8sSTBjD5Im6M2HtO0KoAavODEmffoZei6gJ8e++mfb7JcCeh2f49ktJ9byqoTk/pVHoCO3+1NPtBiGL+KT+0mvsRKQpfNs1QruReery0HLDTGP+Qf635cggZ34AR7ZY9+7jY+kpw8MBGwcsyZS+AAlQtsjL/jywv59STDqj010zTfrBHouzvpfmZGdd/PXpegsmHnwM/FQW/PUHv1C+IvHSPcCFeM6q4OIUcElA2YB/kyGiUvj4Q2tcChbg3w/Z+E/0n5znpAM1gQmteZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/P1+ux9mHVOLxMeDOBsoV9v4M6Cu8m/Pp+GYkISx1X7C+3GS1YexiZG4qKFytNTxZVvlG79xLiuCQeA+tPqE1zPAtWJb4rdUcH8bFAM9lX735gBgdTBwHSpF8/nITLPjXrfgXTCPjGyfhhzVBRKIaL0kWjnXi2BiGyZrT5YYBy2AUdmmUv28nUJ01OfOiSaiTpcMkn2IT9Prsv0FHRLVTQp80Gr7Xdwt4kR87w2UEJIk7Thy8fhzPvBH5oXar/PsNU/0M6UXupIEfKbUpGoXllml4NSJGD4lO2xFSmTEwW67JZ5/7gFuY0gDQC1011U7wsyBBMtoORA6dOQZJQFiw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 11 Aug 2021 08:17:16 +0000
- Ironport-hdrordr: A9a23:/Ark66gA9Xk1MQfK/ar9I9ZCP3BQX1p13DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3I+erhBEGBKUmskqKdkrNhQ4tKOzOWx1dATbsSkbcKpgeAJ8SQzJ8n6U 4NSdkGNDS0NykGsS+Y2njKLz9D+qj+zEnAv463pB0BPGIaCdAU0+46MHf8LqQffng3OXNTLu v42iMonUvFRZ1aVLXAOpFTNNKz1uEj2aiWLyIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7XjoyWsl1P73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhP12dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYAB89IletiA1bkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooFI5+NRjykB3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+ FoEYX1+OtWS1WHdHrU11MfguBEZk5DWStuf3Jy/PB8i1Nt7SlEJgojtY8id047hdYAo8Iu3Z WdDkwA/4s+PPP/bspGda08qIWMezfwqb+lChPaHb3dLtBxB5v6ke+93FwE3pDfRHU29upFpH 3gaiIViYdgQTOgNSWxtKc7uiwlBl/NBwjQ9g==
- Ironport-sdr: Lk3BTADuc9PmmOJB0yWrThC4hlE0s7R/jN3a6Lpc8Jxgr7X4kOQeNfwtm7/M0LchFd+L+RdZTl zfPrZRta8QIcOmufYVIT2By+1mOf6XX2cGLO6+jJgcQqJUrvW5J1szYTgF/k7mjK/NDiA2ZyZ3 bcHXNlE68c4xzI70ftYTjc+tWaEKwLeDuZwtPO1YrMkEPNWImDWsfX5BJzNDtAVaU3dM6gQZAt fieTdFH2wQG/wrQHKM9x3KdsJr6zwTMp7W8C3fjesxOvWyelUlORuAbPOgyYeJSYp2/N1ox1Wf KXfS2PzV3Tx42EZ4xkaeSfyD
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/08/2021 07:08, Jan Beulich wrote:
> On 10.08.2021 19:47, Kevin Stefanov wrote:
>> --- a/xen/common/kexec.c
>> +++ b/xen/common/kexec.c
>> @@ -35,7 +35,7 @@
>> #include <compat/kexec.h>
>> #endif
>>
>> -bool_t kexecing = FALSE;
>> +bool kexecing;
> While not overly important for either of the two present readers,
> I nevertheless wonder whether at this occasion the variable
> couldn't also become __read_mostly. Andrew, thoughts?
Yeah - forgot that.
>
>> --- a/xen/include/xen/kexec.h
>> +++ b/xen/include/xen/kexec.h
>> @@ -17,7 +17,7 @@ typedef struct xen_kexec_reserve {
>> extern xen_kexec_reserve_t kexec_crash_area;
>> extern paddr_t kexec_crash_area_limit;
>>
>> -extern bool_t kexecing;
>> +extern bool kexecing;
> Later in this file there's also a #define of this identifier, which
> imo then wants to also change from expanding to 0 to using "false".
Sounds good too.
~Andrew
|
