[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/xenstore: link in librt


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 13 Aug 2021 14:35:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P56ITVavRR7rAmONoTimKF5xpeKb2AXY2002iQih6cg=; b=NrSFKJQNFwuHeKljP+clDXjzOgPhYZFZiYecxzLFwyiosHPuB1BEG4qYDVL6qZrC1+oSTIaws+Iuisx1KY3mMPIXkW3DB3KUdaosr3nmguzsWLDWNwmLV6uXaoCw1vskaApu9uJl6KjmFFA2zkIrowe+yDXaouhTpgd5gbqUOTZHJfvfDcBk93FdWvYfo8LQnDJHZ0ZQAWPzwvioGzsn37UgxqYm+07jGCd9AK1D+ILsywIGWNIx+0zw/VRHJeboWnFWWo3KzzkxOUncDpDlRwB6mskbN/SiUSiQSsgM/JcEsjlqIEaZprfk47pSLf5RozgyxvSpSrJBiUKJmK73og==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NV2/bHL7vCqGpdh6j3So8UaRPNm64BR4AR2Wal4hDfHPi39q2z1xoynxqWVDDwWMQviKlKAUHbyqWqhinPmVrg2bf+/KCbup3l97LokcfASeaYJT2HLX/gqdDGHw/v1h/rqMjsNA4c9sS4rkM8kYa96RyvM6sbVN6YeepmYPjkWCL180aMxBmk/Xfhdjmhe98imv66/gPwcyRHMSZiIbiiHIPq2T92lzpSM31gMP0Nnt4AWLZuau1kiDUSYAmTinUKVnivRd3LRZ/IaUMFUNbd4MO5/d9GBEo7RDlEgxlGweiKHxLzx3eUYaEA4gilzAAyIvwavXGpaBv5tQrIIq4g==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Fri, 13 Aug 2021 12:35:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.08.2021 13:09, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] tests/xenstore: link in librt"):
>> On 12.08.2021 13:24, Ian Jackson wrote:
>>>> +LDFLAGS += -lrt
>>>
>>> Don't this unconditionally is definitely not right.
>>
>> Assuming you meant "Doing this ..." - why? If the concern is that
>> librt.so may needlessly get recorded in a DT_NEEDED entry, then I
>> can replace the early addition with a late
>>
>> LDFLAGS += -Wl,--as-needed -lc -lrt
>>
>> one.
> 
> librt might not exist at all on some platforms.

Hmm, indeed. Do you have any suggestion then? Adding a ./configure
check is going to be beyond what I'd we willing to spend time on ...

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.