[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ping: [PATCH v2 00/13] x86: more or less log-dirty related improvements

  • To: Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 20 Aug 2021 09:20:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yx9O5pcSjDoxiVNVRlYbcCX9Ny92lc/LeG3Tlsaib8o=; b=iJgEIEf6eRihi1nGEESTtjVO0NcllNPIPXLhYRTfyLix2Bq/G0uPq0aUEbzRGsd3Azdd1Tikf/nryVKJeVTDglx7ppgaNFNE3+uNXRG7c8WXyuxpyJ43+CIWJZyNcHdjz0BkX2OoiLuonz34oQuvzS3A6QtF+q+UhNJR72YNtVS3uHhLBDWFjHXcFDBgT+8jRDljyq0vyFR3JSOFVG7wI2cQgSlM4++lpHZ4bnkppqZejezft4vC3XgzFqtsyOjNSh0nZLQEqS+1ROo90txOJJi2TNmq92CXECAWYZWaRlM7TYzq7ziarQdU0sLF76crFimF6Lyn7IRUc0sJhJLQ7Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=geMWvJGl58hEk+ajkaByLcZAkG1fEYLCz19NKpH8zTBnJarXQP8owSOE7UFWt3VaU2RF5HNPFHxSrpFkGFuZBlV4axQjnCJ7GPg0+IzWXIcyMzWLR08/g7YA752ku8UiCdVgkoA2QSLFL4cLo/+9RdnIcVB8+P0P4SVZjPfsBAfkSpCDp6rYH2LppB2sFK2/sGaXQ/qpVSZ9a2KBkcIBKG7GX5dgEyVh5n9vuRkVwmucCaN0Cy60wAYeNbDEBaj2m1MaaWbpEqgqurllAepVB94vyT0wjhHPH3zxdEHQ28jouKdXRz6YMQNWioTxUEKR58UlIcMuoPqX9stYrqMw3g==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 20 Aug 2021 07:21:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.07.2021 09:46, Jan Beulich wrote:
> On 05.07.2021 17:09, Jan Beulich wrote:
>> ... or so I hope. This series continues the attempt to deal with
>> the ovmf change putting the shared info page at a very high address
>> (which is now planned to get reverted there, but the general
>> problem doesn't go away by them doing so). There are further issues
>> with truncated value, which are being dealt with here. But there
>> are also not directly related changes, when I simply spotted things
>> that aren't very likely to be right the way they are. And then
>> there are also adjustments to the underlying hypervisor
>> implementation, with the goal of making the returned data more
>> useful to the consumers.
>> With these changes in place, a 1Gb guest which has "inflated"
>> itself by putting a page right below the 16Tb boundary migrates
>> successfully, albeit the process takes from some 20 minutes to over
>> half an hour on my test system.
>> In v2, besides integrating 2 patches that were previously sent,
>> there's one new patch and otherwise review feedback addressed
>> (albeit there wasn't any for a number of patches).
>> 01: libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl
> while I did get an R-b from Anthony on this one, but ...
>> 02: libxc: split xc_logdirty_control() from xc_shadow_control()
>> 03: libxenguest: deal with log-dirty op stats overflow
>> 04: libxenguest: short-circuit "all-dirty" handling
>> 05: libxenguest: avoid allocating unused deferred-pages bitmap

with Jürgen's R-b for 2, 4, and 5, may I ask for a maintainer ack on
at least patch 2? While I did address Andrew's comments on v1 of 4
and 5 (verbally), he didn't indicate back whether he was okay with
my replies, so some judgement may need applying there when deciding
whether to also give an ack there. Thanks.

Patch 3 remains controversial as it seems, unfortunately.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.