[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI


  • To: Rahul Singh <rahul.singh@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 20 Aug 2021 09:06:30 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fdZpzaD+AyVoy4zykKcdr0VFCy/g9MjibvR0nMgESdk=; b=kiUYHZhIbZQd32K8pLY77/4rxHdyEUlYCBrsfnHBgXIm3tiunDrhyIq2Z0CnivbpdI3sSGpOHynxUwrzqtEX/rvUuG6VRinwIE82HvPE2gWiArv+x88xCOmJu947YWaH0KxWhim6m0zdqfFrb7zniCxh9ocVrG4pTWZjI+phf2PKbQ2G9pZ9VTS7ffrzCMplp38U5lfZFdPpVcTSa97+AclY2vUSIP66+MxOKS3aTCcU6OHEbTWPBU3FCsipCuI9ot++9KuCp2D07BX3ZAf/i8p2iKwUe57lRGw8h+K8tQ/w9zNyHZknypluYwGOiN3+u9BX47/UMQNIS4/oaXB6BA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLp8OV4AIr6NNJ9ktta+YOIlek3xp+kEOMYXYU7zoqe6URnHylhKx/0VennrgxIEWy1hjyqux4ptDcqKxW65/nj/cDQurqd3ThmnS6AGfC+R4Nfu/M2N4GMeAoEXqnbvaET7iAgfem8ekjam/py2zoP3kK7RVanOr0FG4Uweu847Mzs3pmjbzg+4R7+heZmxbEQb38JBXIQwLXLVHND3p+7uDGaBqw5ryu3PRahTHS6VhvrbtItciQEsZm1CU1Xc1+CWxcBl29IN8OgPW0CLzOLFi14JXGt9N8FFhPNqlgrAowSx7GzVeAj2pai9nM1NvZTtPJo9nWPSEcqkRipNug==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: bertrand.marquis@xxxxxxx, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 20 Aug 2021 07:06:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.08.2021 14:02, Rahul Singh wrote:
> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
> architecture. Move the code under CONFIG_X86 flag to gate the code for
> ARM.

Please give at least one example of what it is that fails to compile.
What an appropriate action is depends on the nature of the error(s),
and from looking at the enclosed code I cannot easily see what it
might be that breaks for Arm.

And as suggested by Julien for the earlier patch - you will want to
re-order things such that compilation doesn't "break" in the first
place. Title and description would then want adjusting accordingly.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.