[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Fri, 20 Aug 2021 11:41:04 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5rK+EobFOx6GLMcK0fCWxmzm62sBElQ0GJY/pOHMjM=; b=azo4sDe9OvNf6QAksihw0EodnnzZfyUYMk/c6yp24JGoGg0rqrZwZPlu87zgia4bjlVuXg1rGjSwLfQVaICOCrmYAVVYie0GOtQkCVfswB8nfnhdnjpgdG6VSz9IO8L7kMfeSHh+oZMx1eTbADjtkQ4mkcrm5gxGapD6gav5hXpkTONvoAntSw1v4YN0iOR0r2HXIsj+w69/8Rh1wZVFXOaTxYsAKU0eYv7FlVJnbpbkVTHXx+Q3c1lc8Nba085sG+08jYG81cQgebUCG4t9jw01JrPg4tms1iErw72FRflqq7IiX+IVG1NaCxqbtxpeAKAD2TAePinCpmpqRYao9w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fFjYqyebfwmRbxBTeQI1fHE3JcGRrkJsGDLUPbOU7XKVe2BWoqH4/qeOkV7gJpDnM//PZC6bbph2xcq+wpBaOaskQn0hSASKM0jW2msyVRoSAQEI9YfDZ+eDR9D73a/8xEiCCARbuwXTY9EF5v5Yyk6oy0f8usbgZmDv/SskqLoeg0Tmo1axINJn7emGp7xSCm79ii0OimJX8+XfSjHNX7qLeAOYaF8DDk8gUgsmTORQRo1UYdlILgf3l5RjmVf3hDhNzgQLLxyrxYwA7oo6fJFkYaaeWX2jkJ1Om7e27cGzb6qhKi7ujutxVWz2z1mI9D2d3asJ7l/3dU3Lv1li4w==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 20 Aug 2021 11:41:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXlPKNppsGoVMjlkS0HQqYv0RYK6t7+ecAgABMtoA=
  • Thread-topic: [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI

Hi Jan

> On 20 Aug 2021, at 8:06 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> On 19.08.2021 14:02, Rahul Singh wrote:
>> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
>> architecture. Move the code under CONFIG_X86 flag to gate the code for
>> ARM.
> Please give at least one example of what it is that fails to compile.
> What an appropriate action is depends on the nature of the error(s),
> and from looking at the enclosed code I cannot easily see what it
> might be that breaks for Arm.

I am observing below error when enabled ACPI && HAS_PCI for ARM.

prelink.o: In function `pcie_aer_get_firmware_first’:
/xen/drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'
/home/rahsin01/work/xen/pci-passthrough-upstream/xen/xen/.xen-syms.0: hidden 
symbol `apei_hest_parse' isn't defined

I found that apei/ is only enabled for x86 and pcie_aer_get_firmware_first() is 
only called from x86 code.
obj-$(CONFIG_X86) += apei/

I am not sure whether we need this code for ARM architecture 
that is why I gate the code for ARM via CONFIG_X86

> And as suggested by Julien for the earlier patch - you will want to
> re-order things such that compilation doesn't "break" in the first
> place. Title and description would then want adjusting accordingly.

Let me reorder  the patch series in next version.
> Jan



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.