[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/14] xen/pci: solve compilation error on ARM with ACPI && HAS_PCI

  • To: Rahul Singh <Rahul.Singh@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 20 Aug 2021 13:54:11 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8llChDX0beL1a49RdUUuRG/UdkGSb3s2buSNQrdoVg=; b=CaaWllUVpYwHgmCaAmSfpuHTc3prqcCnlHe2ZynVFZDA2IeJcwmlmo8fYxffL3AWRl2Pc6wm7vwrC7BQVnGdHLylYtEx+U68jbO7ToiApSC4t4Lw648a3K8iHk3zllYoHO3/iUVZXRo1p41jlbGTuYNTt/WPBDKVoDzrT/fFzjCmhgXRmw6CPBXRCxZiw9xvkOhS+kvcL0dI6xt8fz/zyjbG57asfc2XXqRoTHCd+4pTX4tBYqTvL1kd5HdJDFpXmdKlxwPAScD1uIiA5x3oBueTGeYyEyu3JEcePVgWW8nH8Ni6Jt3okNy+JF3rYUadb4kMeNPqhVZH/cA0vbsB2Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KeGrBNO4JUsGshkMO4OLeDh4bA6Jhp1Np8DL1/gKv0p56RnDlkXdrOFYhsd0pa3uVn+yKekuadEMwzZyonq7SOMVf2xKwfIo1uodORqR+lFbcxefkLuWAXADB9Va8QHLUyWtgh34hISnLhCycVHzlWltbVkSXMh2lC8rCUGfd1e7w1D02GtE+PJf/pS76BAJVgdfkjW2u3lFbYSf7PHJCCSVG8ntWMYrmFi5IWtUnAlzeIxjV/0j+p7YkJViX8iM7wbTtWOy/+AwNvjb6ietyHPrAWf+81CdDZjeibgO45kfMWtFJDlKGypVkx4Yvvq3LyGB3seIy8s/2djRAMdB/Q==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 20 Aug 2021 11:54:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.08.2021 13:41, Rahul Singh wrote:
> Hi Jan
>> On 20 Aug 2021, at 8:06 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 19.08.2021 14:02, Rahul Singh wrote:
>>> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
>>> architecture. Move the code under CONFIG_X86 flag to gate the code for
>>> ARM.
>> Please give at least one example of what it is that fails to compile.
>> What an appropriate action is depends on the nature of the error(s),
>> and from looking at the enclosed code I cannot easily see what it
>> might be that breaks for Arm.
> I am observing below error when enabled ACPI && HAS_PCI for ARM.
> prelink.o: In function `pcie_aer_get_firmware_first’:
> /xen/drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'
> aarch64-linux-gnu-ld: 
> /home/rahsin01/work/xen/pci-passthrough-upstream/xen/xen/.xen-syms.0: hidden 
> symbol `apei_hest_parse' isn't defined
> I found that apei/ is only enabled for x86 and pcie_aer_get_firmware_first() 
> is only called from x86 code.
> obj-$(CONFIG_X86) += apei/
> I am not sure whether we need this code for ARM architecture 
> that is why I gate the code for ARM via CONFIG_X86

So you Arm folks will probably want to settle on that aspect first. What
is wanted to keep things building depends on that.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.