[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/PV: account for 32-bit Dom0 in mark_pv_pt_pages_rdonly()'s ASSERT()s
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 20 Aug 2021 11:30:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0MqlltUNFLQp2EdPyFeJvvWk7s/5tILNlHM2F1TJWk=; b=CwlHtJ2yPtV8ObzuayvyJNlx1F/KvoIYIfhrDhpgJzbqU/oRk64EQ0tcusO7RezOtIixw4UxvsvCbhr3ULDTXb/k1fDs6kft7KfrnXuhsMFVfLFoEsGeTKOKd0LUOoVpZAMp8eDYyu46il2eAHQUnRAsJdtU4UiGS3eSZLk1Y3/+OdsecvBVZB4nVIBQxRYmcqnLg+YGPBwpemP8Pp+CyhKnBXaDvjeX1av/1AoyjrRkGJgBICvB6sZrH/SeXxbr0D7kFnBc06Mhdl83X27tOeFew19xyGQtfY/qb9sMHOwfXDjmTVENVrBfcS4egway9fuHuXDy7Yc3dZip58msng==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZyC7QDYBX/SGEwuf+fM6QlzJ11eg7yFyxZkHL3VfPn9LWxV4Xgx8aKbTpBBvE2h1+au2tAXnhekssB3mJmXP4Fmfiy4BGdrC/je5oJkLnBAFI50TddEXT0Ys6TN2VggZf5WvmC+/fYWy2t03FRFjD6qOfUt2f5kGs7QT1NwPBacVxoLgaj6rSbvUc45bvnmSfC55ZbUjMJz37a6oBbYApU2D54ksrinB5je6Tamj0Cb2DlvaEhs//H1VHS85mPtAnxEH7WPQb/oWcCIfizJFt51endKfpUPMN2I5nGXTsdM5nWL7Y9AwAdki1USuPgxJqlaUVEN3CWVWxHYOneovWA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 Aug 2021 09:30:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.08.2021 11:13, Andrew Cooper wrote:
> On 20/08/2021 07:22, Jan Beulich wrote:
>> Clearly I neglected the special needs here, and also failed to test the
>> change with a debug build of Xen.
>>
>> Fixes: 6b1ca51b1a91 ("x86/PV: assert page state in
>> mark_pv_pt_pages_rdonly()")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/arch/x86/pv/dom0_build.c
>> +++ b/xen/arch/x86/pv/dom0_build.c
>> @@ -67,7 +67,7 @@ static __init void mark_pv_pt_pages_rdon
>> */
>
> ^ this comment needs adjusting too.
I didn't precisely because ...
> Presumably this is because PGT_pae_xen_l2 is logically part of the type?
... I would have viewed it this way. But I'll send v2 in a minute.
Jan
|
