[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled

  • To: Julien Grall <julien@xxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 20 Aug 2021 13:55:25 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8xAUhEBDar5YM7Ezl9VSQJIR+KltFHLR4zA7sENwrw=; b=LrdcRGZishHOdx9ZeOZHpDEU5wVd/rKn36YE6p+lU81OTpF6dgMgrE5efJYgjHJN3PrZR5Saww2/9kK9BrNrSah1nPBx9P/iNuI7Qeall/Da4n1jmNzq8wgHVqwAuAf/Py9g+xidIlVfQ71Y0D+1WSprQmzIFvsROt/Y+55PS4aOYa5ESwW+nUq/fLWZyNKf7ZoznVBxNJb6ORUXyuTLmxLL0EUg7qvhJaBNbhnY1SNyS7N/qINI/Me6Fbzf7SIylrY9ikdguCgLPbcAd6Ag8eYDEB/XqXuIVlrs0rUugMMfnkqKQnylSfE0u2PWGHjmVTa/FjzvoSv5X6n1TAGIlg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPH7rR5aW1Or7Cqdg6fq1k6dTgQxcwMqXncAGSXE0RsrdBVulOcgOkrQZhD4GimC+oa19io/LgfsOb997kXzSePhUbROj544YV+V6CRTxQNl9HWSwtzM1GkH8BjigZ86wOkI+S8dxNtZLw7ORER3bVVt2ofVCtcF+O73vv9hHuCv0ubRNeBA4GTFv48twie9m7emhfbgKh4elZKFuoPWRLon4rkFEoWxmZZAMAHkQVbZaLMfKO/dO90WFTRZRawsCb3rKbpqXJvYxYx+334J669vBpJBDCc2BAeIabGzBSJjd/RbEzuF2gub4UlPxlS5z9KlP0OIGJJI0sbJjV3Now==
  • Authentication-results: epam.com; dkim=none (message not signed) header.d=none;epam.com; dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 20 Aug 2021 11:55:33 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.08.2021 13:37, Julien Grall wrote:
> On 20/08/2021 11:30, Rahul Singh wrote:
>>> Please add a comment explaining why this just returns 0.
>> Here is the comment that I will add in next version.
>> /*
>>   * Return 0 as on ARM there is no pci physical irqs that required cleanup.
>>   */
> In this context, PIRQ means an interrupts that was routed to the guest 
> and could be mapped to an event channel. We have no such concept on Arm 
> (see allocate_pirq_struct()).
> So I would write "PIRQ event channels are not supported on Arm, so 
> nothing to do".

Does this mean ASSERT_UNREACHABLE() might be appropriate here?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.