[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled

Hi Jan,

On 20/08/2021 12:55, Jan Beulich wrote:
On 20.08.2021 13:37, Julien Grall wrote:
On 20/08/2021 11:30, Rahul Singh wrote:
Please add a comment explaining why this just returns 0.

Here is the comment that I will add in next version.
   * Return 0 as on ARM there is no pci physical irqs that required cleanup.

In this context, PIRQ means an interrupts that was routed to the guest
and could be mapped to an event channel. We have no such concept on Arm
(see allocate_pirq_struct()).

So I would write "PIRQ event channels are not supported on Arm, so
nothing to do".

Does this mean ASSERT_UNREACHABLE() might be appropriate here?

Unfortunately no. This is call unconditionally from pci_release_devices().


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.