[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] x86/debugger: separate Xen and guest debugging debugger_trap_* functions
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Aug 2021 15:07:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCLrBAJHoTKUwYGmyV6hl09i2N5TYjzrXVJ8LOw8ekQ=; b=V17TG2mVsb2Wj/5bOgccw5RI6dov5hCnUwst0KK0EPQsrfPsK5w7iKEyPl9VqkCUwoKdkXJ5VIkwvhOagZYIEXsNhcM6eIoF/FnlQz585kvCq7Ue9NQI1Pig2tXkjq6OfTQPyrCowyV8+zIZW+dBwpwc2kR6HuXAPBjImAWTKcYeMAHDmv3ka5txf7rAFalrzBmpbULoPyL0biwkX3TcBpZEGOChgRxZqSirmtLPBMqXDdVMQwdYQ41auORsKLq9S8LQ2gJweZmYYU1LepGmcDx6dz0TyJJcxOrgsJAe9kRdNjf7GDJLl/2Mmn1A3R6MytDvDhUmjyHDMdPRv5KGyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FReLfFVTij874BmnkwB3du0Erz9N9h1jHAb8juyjj/erX1omqdXULTjia7HTy+0F1/WT7xgvq1Vp79pwLrr3EELtsVplU37Iis/yK4bbAFQnbKbrF2XCZpGi8FSW/oMnPhjdpwRnpxVR0EgczgtsIbAlKVt4+KaiSd+Vcz1upsLnFUZJd3g1EZuN1Kh8NGLMafWfHCxcJDz0aJ1mAp1kIY3NxJvb/EY1ln9J6kUtR16erMPSS382xVKfY3HL44AZTLY/XBHy5mCd+KRdrkgDedFtd86hcHwEP+p7cdxHEpKbsJTRrihYII0Ozfh3EamnADHSNABXKvn/2ISjdd3UMA==
- Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- Delivery-date: Tue, 24 Aug 2021 13:07:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 14:41, Andrew Cooper wrote:
> On 24/08/2021 13:16, Jan Beulich wrote:
>> On 18.08.2021 22:29, Bobby Eshleman wrote:
>>> Unlike debugger_trap_fatal() and debugger_trap_immediate(),
>>> debugger_trap_entry() is specific to guest debugging and *NOT* the
>>> debugging of Xen itself. That is, it is part of gdbsx functionality and
>>> not the Xen gdstub. This is evidenced by debugger_trap_fatal()'s usage
>>> of domain_pause_for_debugger(). Because of this, debugger_trap_entry()
>>> does not belong alongside the generic Xen debugger functionality.
>> I'm not convinced this is what the original intentions were. Instead I
>> think this was meant to be a generic hook function which initially
>> only cared to deal with the gdbsx needs.
>
> It doesn't exactly matter what the original intentions where - what we
> currently have is unused and and a clear source of confusion between two
> unrelated subsystems.
>
> It is unclear that the gdbstub is even usable, given at least a decade
> of bitrot.
>
> Keeping an empty static inline in the enabled case is nonsense, because
> at the point you need to edit Xen to insert some real debugging, there
> are better ways to do it in something which isn't even a catch-all
> despite appearing to be one.
Perhaps I should have said explicitly that my remark isn't an objection
to the code change, but a suggestion to weaken the claims made in the
description.
Jan
|
