[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 12/51] build: avoid building arm/arm/*/head.o twice

  • To: Julien Grall <julien@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 24 Aug 2021 16:12:26 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 24 Aug 2021 15:12:34 +0000
  • Ironport-hdrordr: A9a23:amhi0aGXFjLRI1u6pLqEiceALOsnbusQ8zAXPidKOH9omxej9/ xG88536faZslgssQ8b9exoUZPoKRi3yXcf2+gs1NmZMzXbhA==
  • Ironport-sdr: c6Zq0P2Ve4+9EXyKLtGztq2myGlhfANiQpGNZAqLhUQLFZSD59J40DDxgDMSMR6Rd3kUQL14JQ SbQ6bl+g5Ce8bd4SAQjGj8k9mQVbGHOpQlnsC2eIO6sPuRj0nP9kPG1E1rGk4WyASZjiiV3kxF ATNoKdItYC2uSQd71ed7cHHgZ7NJZe0V+u5g3nk/LJYvs+juK1eCjTyvSqCyxCJxXhPt2OP1d6 m4HMd2hpUzNY5elOLxR1jkIwM4E3Fw/2ADRRTs3x02WsiOFHcBMDEyoXziq/cpHNjsC0pp0OJ+ 4IefCrM3La+GvEnO5+XNcLyi
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Aug 24, 2021 at 01:53:11PM +0100, Julien Grall wrote:
> Hi Anthony,
> On 24/08/2021 11:49, Anthony PERARD wrote:
> > head.o is been built twice, once because it is in $(ALL_OBJS) and a
> > second time because it is in $(extra-y) and thus it is rebuilt when
> > building "arch/arm/built_in.o".
> > 
> > Fix this by adding a dependency of "head.o" on the directory
> > "arch/arm/".
> > 
> > Also, we should avoid building object that are in subdirectories, so
> > move the declaration in there. This doesn't change anything as
> > "arch/arm/built_in.o" depends on "arch/arm/$subarch/built_in.o" which
> > depends on $(extra-y), so we still need to depend on
> > "arch/arm/built_in.o".
> head.o as to be right at the beginning of the binary. Will this still be
> guaranteed with this change?

I guess what you want to know is: no change to the final binary.

The layout of the final binary is defined by $(ALL_OBJS), which this
patch doesn't change.

This patch only ask make that when it want to build "head.o", it need
first to build "arm/built_in.o", then "head.o" exist so we ask make to
not do anything in this Makefile.


Anthony PERARD



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.