[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN RFC PATCH 14/40] xen/arm: set NUMA nodes max number to 64 by default
- To: Julien Grall <julien@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 25 Aug 2021 15:36:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5yBe8Hvv7zc3FkHE4IXqCzJ9+eCANw5xhSl8y3cF6o=; b=CA94Zi1L27u4lL5SWRfp4YmrPJGq20pyjLLJBjy0k6L0T88zT+A8vcjfT1k4mCa0P7PPJM9jSEE3vaEroSiS+kNcAuxBrK9dBxB1Axk32QsdgmFNA9j3PWuiRO6/0c/rs88+017cuvizdrvbZwfl2GgJE4Bty8SdpFN3igpckOiigbH3ST+bALH1iuJ7HSW/YvQxA1/f4IQhtqUBC78n6esFiHuONMoHIYlCh8vqEyDoGDRxbYt09sPE6LE6kFSMaO8F1jYW6wlp0kWSkRWXKwicYzUQt3IdPLGd9MNHrZ3JfSTwrpSZKekediyTcN/yIIJAzbCM9GtR093g0CWVqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MxRf7bjHfxz09Mrcle8HzXo6syWQMgBvwtUCMIuzBJsrRQiqnKGMM6HoBTYmMxC5buCZfvhEyqK36nhprMB74VTvxDWLJI/CMluC6+3QIHhBRQ0w7KoteG1l1CwcNpMKst3CqeIGReMkVN2dZa8fOIGXO4woVVfbE9941n5w0KWVMEP/0wMby1QVGLvfUUthUxcd9mQIcp2GBl+C7Lu5Lmk+yVQI4/BR7Ol+hXwY640u1dWCdKHSSTUg+7cGtpa99nJSmKzAKtY7nkOvvFanCetn7IWV8cpK4ffCpPafMEFtWJrvLwSukVCrdvnTV7nRLuQGWWxHvOoqnxwlKf+fkw==
- Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
- Cc: Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx
- Delivery-date: Wed, 25 Aug 2021 13:36:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.08.2021 15:28, Julien Grall wrote:
> On 11/08/2021 11:23, Wei Chen wrote:
>> --- a/xen/include/asm-arm/numa.h
>> +++ b/xen/include/asm-arm/numa.h
>> @@ -5,7 +5,15 @@
>>
>> typedef u8 nodeid_t;
>>
>> -#if !defined(CONFIG_NUMA)
>> +#if defined(CONFIG_NUMA)
>> +
>> +/*
>> + * Same as x86, we set the max number of NUMA nodes to 64 and
>> + * set the number of NUMA memory block number to 128.
>> + */
>
> Such comment can rot easily if x86 decides to bump there values. But
> given the value is the same, I think it would make sense to move the
> define to xen/numa.h.
To be honest - if this gets moved, please at least consider making it
a proper Kconfig setting. Just as much a the number of CPUs can be
configured, the number of nodes should be possible to choose by the
build manager. Of course - if it's not too much trouble ...
Jan
|
