[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [XEN RFC PATCH 14/40] xen/arm: set NUMA nodes max number to 64 by default
- To: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Thu, 26 Aug 2021 02:26:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sbn4mjJ2jxToEN5TilOhqTYts0V1eQ1gVjZhzT1+9Bw=; b=CIuti0ow/YxsOFaYgeGJj4bKdBCRj7pR2MoCg/RD2UaZ/9sURXGBiUvSc/OQ54lQIRW/+Kw3racxwNVogNwspAi8BD+Z9ElCKWKfufhIjwSQFfsohOx3ElpMbHdi5tNNnpWYEOQY1+uT9HWoAJt2eyMb2uS4H+yQVgMgePb4VmpB8TJTXckjUMLBSVD6YSCA+xB7oWe9pSyox2E8fH9bA1J1BznNxwqsUXEWlz0dCu/EHzC3aVB6PHo+ihQvv+Li8GPnf+zmhd+++AFI1fpNEiQJxnRBmzzHunbQNaUnYWkg8OtLbHLTZ6X8Qyj45C8qZdAlbPk9BDLgFIeC4eUdNA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LaYSyR5VgQIEHeuuCqhwL8bV/JXhradZXoyGsMg7vIXU5GqrfJThlYyMQq7x5dk0jVUxnwrFW2vsiZNx8BVMBjUSpvot+WgkF/06gME/U3/NmUZs6S6N7R1sv+kFixRcsT8SR+VxecKzaCFiVpa41V92iqaYldcopK5u0gQnUAESH6Au/h76dVlTpEuVzh6h0urpOjNGnsVkCNi++2GCt7tlMr2t8uW+DFd4Mn/uOXWG5e2zZQQYeBRGL9aeDABrNg18RgqrBl4TD8f+QeuijcGlRmJsx2E1Ki12Zi/X81R80cAdZT7/EdXDh68BJ0/meo9JcwNoaClm3WSSXm6/BA==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 26 Aug 2021 02:26:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXjptAJmZokCLLIECfY7e+eVRE+6uETQoAgAACFICAANcfwA==
- Thread-topic: [XEN RFC PATCH 14/40] xen/arm: set NUMA nodes max number to 64 by default
Hi Jan, Julien,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2021年8月25日 21:36
> To: Julien Grall <julien@xxxxxxx>; Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx
> Subject: Re: [XEN RFC PATCH 14/40] xen/arm: set NUMA nodes max number to
> 64 by default
>
> On 25.08.2021 15:28, Julien Grall wrote:
> > On 11/08/2021 11:23, Wei Chen wrote:
> >> --- a/xen/include/asm-arm/numa.h
> >> +++ b/xen/include/asm-arm/numa.h
> >> @@ -5,7 +5,15 @@
> >>
> >> typedef u8 nodeid_t;
> >>
> >> -#if !defined(CONFIG_NUMA)
> >> +#if defined(CONFIG_NUMA)
> >> +
> >> +/*
> >> + * Same as x86, we set the max number of NUMA nodes to 64 and
> >> + * set the number of NUMA memory block number to 128.
> >> + */
> >
> > Such comment can rot easily if x86 decides to bump there values. But
> > given the value is the same, I think it would make sense to move the
> > define to xen/numa.h.
>
> To be honest - if this gets moved, please at least consider making it
> a proper Kconfig setting. Just as much a the number of CPUs can be
> configured, the number of nodes should be possible to choose by the
> build manager. Of course - if it's not too much trouble ...
>
Ok
> Jan
|
