[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/17] IOMMU/x86: drop pointless NULL checks
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 26 Aug 2021 13:05:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CW4zszwH+uMfb+wAtRh/cHck6dERhPvuR6MygtVQZZ4=; b=oMkOoVnaeA/rGVnAv2XkC6umfZ4G4r78eix/Tz4LdsFu2ay3AJXLst3LTl8IFVKPNWkrorxj/Cg6RQx5uqIhcXcE2G+UQU0mTQQHBEiPLWokNwuE1lfr6p0R3z/i2YCLvZ3ddGqXDktrpzxxAmPCNyvgTIIXVVz05um70jg4KMdRA5SfahhdyfUSdLQ3rhAap/JHvr+xO24EfAJu25CUZ39ZubsvJtCETS/vwojaWdiZyCa0y4tocLXPnkWcahirNzqN9dPSZ2BVqbR/VBNkMLEGe/1GupY1Pe+UKNcPiIe2JdbFUCTMHbHViVHX8jIN8c60Evv3AAAcFgLOzU+utw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1cCOIAjBN5+h0hyz7bwtfLxP5k96fifONrg9ux12h75s3XyQ+UfIBYAzZS4sgpiu/zzu/G22PpOW+4T6P4QahIMaNIvyqZXudOaktG1SovHuGXMErxzS6bx75T9fH3SDNyNa3lZuZpgAyqek44aGiA55J+3NReb7WIJ8fdmcjB6cWHf3Jf5/0vsLbumTB5MhQv9MDcDRKMWy4rX+XonXl42sCFXunl6J7UIj33XyqxefgnMfzh9dDzjvc8Jmn697oUKKgMyZjSQb36vfqwYXJFg4zmdy4a9z9ZrYJiLCAX5R/tUwwWxXNLfOuUWNgOkuKBziQU4VO16u7E07PxKjQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
- Delivery-date: Thu, 26 Aug 2021 12:05:39 +0000
- Ironport-hdrordr: A9a23:+OXDgKEeXhQOolmmpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
- Ironport-sdr: Ty+41LiYL5WHjt0RJ2l3UyTtmP1nfE/iA9qi+SI4wRbJdrJQ7+46PA9SVX6Bb3EBWUea+QhhsW +Mm8nV/Y3pIPqStRB2zxloAIZmYaUivL+VCjISRz7KhMC9Zjo4JRty8SiNkNYvK9Lv9DgoJ003 r0XyoSzU1sWTqFyVkEJah19zKylJXOTGwfZlYsYKjSbOHubW1L5U4cRdusXDqEvVF7YxebZhiy xCnDLADEq7OJeA+4sxeQDGzuQDfRBjf3kY7Nn1nNKM8cJFLQ57d8p3fDLqIvKi5aJrRH185PsG P6VexbVjJwRQGVpS8gVO02Cj
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/08/2021 15:27, Jan Beulich wrote:
> --- a/xen/drivers/passthrough/vtd/utils.c
> +++ b/xen/drivers/passthrough/vtd/utils.c
> @@ -106,11 +106,6 @@ void print_vtd_entries(struct vtd_iommu
> }
>
> root_entry = (struct root_entry *)map_vtd_domain_page(iommu->root_maddr);
Seeing as you're actually cleaning up mapping calls, drop this cast too?
Either way, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> - if ( root_entry == NULL )
> - {
> - printk(" root_entry == NULL\n");
> - return;
> - }
>
> printk(" root_entry[%02x] = %"PRIx64"\n", bus, root_entry[bus].val);
> if ( !root_present(root_entry[bus]) )
>
|
