[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 17/17] IOMMU/x86: drop pointless NULL checks


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 26 Aug 2021 14:36:14 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=24GvBSz44Z4/ZIPIAoyecQ8t5HGaUPkCz/TIDdKwSuE=; b=QbE4fmlMmsqRQ5ud6uqMag8toe+ldHFBDfR5daEg6lP9+T7XI8Zi7ucjMRv/sXVTC0FTUhGZKnjMiE13Q1zM71sxJAto06HkvucOMmq50/bUqkDkxpsk6OlkP9vsj9f1CXB3afQTn0YuARuOLkSr0ByUuxM/RzwVVF5SjPZ5vWKK05a4ddAyCn+I+VASqqAbMxuGffRQzruTVa3rWwDLC+xEQ3PBfKGSQfMirVxg9aRw28TIjuj1dVyLaj3j/O5Jldmrch2KOMYngoHmL1lOOpirHnthlIDf1691Wu52bBg5h6Uy4ejY0WDNJQ9RpBIEW/Y3vwMT/oqJ3epc12PIPA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpfc7ZhypjDJhAJxQF5NeZ6JuEj0qyjkul2WqVd5sRA2FYMNop5kZzsX0X2dwcBn4t6PGY552hF0GZvHpqw4Ek24N7a0tPpSY7FqgCQ7kGRM4Sna85HYMmuB8ZET9UFP+4IDMRE+rvOv8Hyp4hnR3u2CvLX81k/kJOKRkF0v+P6GW7QPdp+iczr6CSCIvrHlz/FV+P0sT6B75FKpU1K8HWBymsIuq9iFXLX/SZtgq7wBwAc2IrmFB/viDTNGr5bjmbz/ergumX13cElY38knxC3uytgDr58d80oFeEBxEMb6DhmnqszUY8WljNP1edHkaFgS68j1jybHr+2kK5om+w==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 26 Aug 2021 12:36:33 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.08.2021 14:05, Andrew Cooper wrote:
> On 24/08/2021 15:27, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/vtd/utils.c
>> +++ b/xen/drivers/passthrough/vtd/utils.c
>> @@ -106,11 +106,6 @@ void print_vtd_entries(struct vtd_iommu
>>      }
>>  
>>      root_entry = (struct root_entry 
>> *)map_vtd_domain_page(iommu->root_maddr);
> 
> Seeing as you're actually cleaning up mapping calls, drop this cast too?

There are more of these, so this would be yet another cleanup patch.
I didn't get annoyed enough by these to put one together; instead I
was hoping that we might touch these lines anyway at some point. E.g.
when doing away with the funny map_vtd_domain_page() wrapper around
map_domain_page() ...

> Either way, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.